I got the following compile warning in 2.4.22-pre10:
<-- snip -->
...
gcc -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.22-pre10-full/include -
Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc -iwithprefix
include -DKBUILD_BASENAME=sbc60xxwdt -c -o sbc60xxwdt.o sbc60xxwdt.c
sbc60xxwdt.c: In function `sbc60xxwdt_init':
sbc60xxwdt.c:338: warning: label `err_out' defined but not used
...
<-- snip -->
The following simple fix (taken from 2.6.0-test2) fixes it:
--- linux-2.4.22-pre10-full/drivers/char/sbc60xxwdt.c 2002-11-29 00:53:12.000000000 +0100
+++ linux-2.6.0-test2-full/drivers/char/watchdog/sbc60xxwdt.c 2003-07-27 19:05:13.000000000 +0200
@@ -335,7 +340,7 @@
release_region(WDT_START,1);
err_out_region1:
release_region(WDT_STOP,1);
-err_out:
+/* err_out: */
return rc;
}
I've tested the compilation with 2.4.22-pre10.
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
Adrian,
I really prefer having these warning fixes, even if they are Obviously
Right (tm), come to me through the maintainer.
If the respective maintainers dont respond in lets say 1 month, then
please resend me saying "I've tried to contact the maintainer with no
success".
I appreciate your work, but I also care about driver maintainers.
Thank you.
On Sun, 3 Aug 2003, Adrian Bunk wrote:
> I got the following compile warning in 2.4.22-pre10:
>
> <-- snip -->
>
> ...
> gcc -D__KERNEL__
> -I/home/bunk/linux/kernel-2.4/linux-2.4.22-pre10-full/include -
> Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc -iwithprefix
> include -DKBUILD_BASENAME=sbc60xxwdt -c -o sbc60xxwdt.o sbc60xxwdt.c
> sbc60xxwdt.c: In function `sbc60xxwdt_init':
> sbc60xxwdt.c:338: warning: label `err_out' defined but not used
On Tue, Aug 05, 2003 at 01:36:17PM -0300, Marcelo Tosatti wrote:
> Adrian,
Hi Marcelo,
> I really prefer having these warning fixes, even if they are Obviously
> Right (tm), come to me through the maintainer.
>
> If the respective maintainers dont respond in lets say 1 month, then
> please resend me saying "I've tried to contact the maintainer with no
> success".
>
> I appreciate your work, but I also care about driver maintainers.
that's OK.
I'll try to follow this.
> Thank you.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed