Urban?
---------- Forwarded message ----------
Date: Wed, 28 Jan 2004 14:21:53 -0500
From: Arjan van de Ven <[email protected]>
To: Linux Kernel Mailing List <[email protected]>
Subject: Re: [PATCH] smbfs: Large File Support (3/3)
On Wed, 2004-01-28 at 06:05, Linux Kernel Mailing List wrote:
> diff -Nru a/include/linux/smb.h b/include/linux/smb.h
> --- a/include/linux/smb.h Wed Jan 28 04:02:56 2004
> +++ b/include/linux/smb.h Wed Jan 28 04:02:56 2004
> @@ -85,7 +85,7 @@
> uid_t f_uid;
> gid_t f_gid;
> kdev_t f_rdev;
> - off_t f_size;
> + loff_t f_size;
> time_t f_atime;
> time_t f_mtime;
> time_t f_ctime;
ehhmmmm doesn't this change the userspace ABI incompatibly ???
On Fri, 30 Jan 2004, Marcelo Tosatti wrote:
>
> Urban?
>
> ---------- Forwarded message ----------
> Date: Wed, 28 Jan 2004 14:21:53 -0500
> From: Arjan van de Ven <[email protected]>
> To: Linux Kernel Mailing List <[email protected]>
> Subject: Re: [PATCH] smbfs: Large File Support (3/3)
>
> On Wed, 2004-01-28 at 06:05, Linux Kernel Mailing List wrote:
>
> > diff -Nru a/include/linux/smb.h b/include/linux/smb.h
> > --- a/include/linux/smb.h Wed Jan 28 04:02:56 2004
> > +++ b/include/linux/smb.h Wed Jan 28 04:02:56 2004
> > @@ -85,7 +85,7 @@
> > uid_t f_uid;
> > gid_t f_gid;
> > kdev_t f_rdev;
> > - off_t f_size;
> > + loff_t f_size;
> > time_t f_atime;
> > time_t f_mtime;
> > time_t f_ctime;
>
> ehhmmmm doesn't this change the userspace ABI incompatibly ???
How would userspace get access to a smb_fattr struct?
(Which ioctl/syscall, etc? Not that they can include the header.)
It is used internally to keep data that you would otherwise find in the
inode, and data is copied to/from the corresponding inode fields for some
operations.
What am I missing?
/Urban