2002-10-05 20:48:41

by Francois Romieu

Subject: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

drivers/atm/iphase.c:tx_intr()
[...]
1684 spin_lock_irqsave(&iadev->tx_lock, flags);
1685 ia_tx_poll(iadev);

ia_tx_poll ->
ia_hack_tcq ->
ia_enque_rtn_q ->
IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);

Driver does not seem maintained. Please apply.

--- linux-2.4.20-pre9.orig/drivers/atm/iphase.c Sat Oct 5 15:51:28 2002
+++ linux-2.4.20-pre9/drivers/atm/iphase.c Sat Oct 5 22:44:18 2002
@@ -124,7 +124,7 @@ static void ia_enque_head_rtn_q (IARTN_Q
}

static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) {
- IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
+ IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC);
if (!entry) return -1;
entry->data = data;
entry->next = NULL;

2002-10-07 19:46:15

by Marcelo Tosatti

Subject: Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

On Sat, 5 Oct 2002, Francois Romieu wrote:

> drivers/atm/iphase.c:tx_intr()
> [...]
> 1684 spin_lock_irqsave(&iadev->tx_lock, flags);
> 1685 ia_tx_poll(iadev);
>
> ia_tx_poll ->
> ia_hack_tcq ->
> ia_enque_rtn_q ->
> IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
>
> Driver does not seem maintained. Please apply.
>
> --- linux-2.4.20-pre9.orig/drivers/atm/iphase.c Sat Oct 5 15:51:28 2002
> +++ linux-2.4.20-pre9/drivers/atm/iphase.c Sat Oct 5 22:44:18 2002
> @@ -124,7 +124,7 @@ static void ia_enque_head_rtn_q (IARTN_Q
> }
>
> static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) {
> - IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
> + IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC);
> if (!entry) return -1;
> entry->data = data;
> entry->next = NULL;

It seems correct. Have you tried to send this to Peter Wang
<[email protected]> ?

2002-10-07 22:11:17

by Francois Romieu

Subject: Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

Marcelo Tosatti <[email protected]> :
[...]
> It seems correct. Have you tried to send this to Peter Wang
> <[email protected]> ?

Not this one. Last try was something like:

[...]
The original message was received at Sat, 13 Jul 2002 10:37:02 -0500 (CDT)
from uucp@localhost

----- The following addresses had permanent fatal errors -----
<[email protected]>
(reason: 550 <[email protected]>... User unknown)

--
Ueimor

2002-10-08 08:40:25

by Adrian Bunk

Subject: Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

On Tue, 8 Oct 2002, Francois Romieu wrote:

> Marcelo Tosatti <[email protected]> :
> [...]
> > It seems correct. Have you tried to send this to Peter Wang
> > <[email protected]> ?
>
> Not this one. Last try was something like:
>...

Mitchell Blank Jr <[email protected]> is the current ATM maintainer, could
you try to contact him?

cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox

2002-10-08 10:55:47

by Francois Romieu

Subject: Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

[cc trimmed]

Adrian Bunk <[email protected]> :
[...]
> Mitchell Blank Jr <[email protected]> is the current ATM maintainer, could
> you try to contact him?

Just bounced.

--
Ueimor