2003-07-24 11:36:50

by Wojciech 'Sas' Cieciwa

[permalink] [raw]
Subject: 2.6.0-test1-ac3 and PPC

Hi,
I try to build 2.6.0-test1-ac3 on PPC

in .config I have:

CONFIG_SMP=y
CONFIG_IRQ_ALL_CPUS=y
CONFIG_NR_CPUS=32
# CONFIG_ALTIVEC is not set
CONFIG_TAU=y
# CONFIG_TAU_INT is not set
# CONFIG_TAU_AVERAGE is not set
CONFIG_CPU_FREQ=y
CONFIG_CPU_FREQ_PROC_INTF=y
CONFIG_CPU_FREQ_24_API=y
CONFIG_CPU_FREQ_PMAC=y

and I got error:
CC arch/ppc/platforms/pmac_cpufreq.o
arch/ppc/platforms/pmac_cpufreq.c: In function `do_set_cpu_speed':
arch/ppc/platforms/pmac_cpufreq.c:180: error: `CPUFREQ_ALL_CPUS' undeclared (first use in this function)
arch/ppc/platforms/pmac_cpufreq.c:180: error: (Each undeclared identifier is reported only once
arch/ppc/platforms/pmac_cpufreq.c:180: error: for each function it appears in.)
make[1]: *** [arch/ppc/platforms/pmac_cpufreq.o] B??d 1
make: *** [arch/ppc/platforms] B??d 2

I solve this with included patch.

Please check and applay.

Thanx.
Sas.
P.S.
In file include/asm-ppc/smp.h is missing line:
#include <inclide/threads.h>
--
{Wojciech 'Sas' Cieciwa} {Member of PLD Team }
{e-mail: [email protected], http://www2.zarz.agh.edu.pl/~cieciwa}


Attachments:
pmac_cpufreq.patch (344.00 B)

2003-07-24 17:04:06

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: 2.6.0-test1-ac3 and PPC

Proper fix is to set it to 0 actually, I'll send patches to Linus when
I'm back from OLS, along with the longstanding driver updates

Ben.