2007-08-08 21:08:37

by Alan Stern

[permalink] [raw]
Subject: [PATCH] hex_dump: add missing "const" qualifiers

This patch (as956) adds a couple of missing "const" qualifiers to the
print_hex_dump library routines.

Signed-off-by: Alan Stern <[email protected]>

---

Is this suitable for merging right away? It should be safe enough.

Alan Stern



Index: usb-2.6/include/linux/kernel.h
===================================================================
--- usb-2.6.orig/include/linux/kernel.h
+++ usb-2.6/include/linux/kernel.h
@@ -224,9 +224,9 @@ extern void hex_dump_to_buffer(const voi
char *linebuf, size_t linebuflen, bool ascii);
extern void print_hex_dump(const char *level, const char *prefix_str,
int prefix_type, int rowsize, int groupsize,
- void *buf, size_t len, bool ascii);
+ const void *buf, size_t len, bool ascii);
extern void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
- void *buf, size_t len);
+ const void *buf, size_t len);
#define hex_asc(x) "0123456789abcdef"[x]

#ifdef DEBUG
Index: usb-2.6/lib/hexdump.c
===================================================================
--- usb-2.6.orig/lib/hexdump.c
+++ usb-2.6/lib/hexdump.c
@@ -145,9 +145,9 @@ EXPORT_SYMBOL(hex_dump_to_buffer);
*/
void print_hex_dump(const char *level, const char *prefix_str, int prefix_type,
int rowsize, int groupsize,
- void *buf, size_t len, bool ascii)
+ const void *buf, size_t len, bool ascii)
{
- u8 *ptr = buf;
+ const u8 *ptr = buf;
int i, linelen, remaining = len;
unsigned char linebuf[200];

@@ -189,7 +189,7 @@ EXPORT_SYMBOL(print_hex_dump);
* rowsize of 16, groupsize of 1, and ASCII output included.
*/
void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
- void *buf, size_t len)
+ const void *buf, size_t len)
{
print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, 16, 1,
buf, len, 1);