2009-12-09 05:56:49

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: staging tree build failure

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/net/usb/kaweth.c: In function 'kaweth_open':
drivers/net/usb/kaweth.c:719: error: implicit declaration of function 'usb_autopm_enable'

Caused by commit b3f937e6ddf3e60ed9b4c26349b7b171dffdd010 ("USB: prepare
for changover to Runtime PM framework").

I have reverted that commit for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (477.00 B)
(No filename) (198.00 B)
Download all attachments

2009-12-09 06:03:49

by Stephen Rothwell

[permalink] [raw]

2009-12-09 15:29:18

by Alan Stern

[permalink] [raw]
Subject: Re: linux-next: staging tree build failure

On Wed, 9 Dec 2009, Stephen Rothwell wrote:

> Hi Greg,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/net/usb/kaweth.c: In function 'kaweth_open':
> drivers/net/usb/kaweth.c:719: error: implicit declaration of function 'usb_autopm_enable'
>
> Caused by commit b3f937e6ddf3e60ed9b4c26349b7b171dffdd010 ("USB: prepare
> for changover to Runtime PM framework").
>
> I have reverted that commit for today.

This should have been okay because of Oliver's patch:

http://marc.info/?l=linux-netdev&m=125071045301270&w=2

which removed the offending reference. Hasn't it been merged yet?
It was submitted back in August.

Alan Stern

2009-12-09 20:40:32

by Greg KH

[permalink] [raw]
Subject: Re: linux-next: staging tree build failure

On Wed, Dec 09, 2009 at 10:29:22AM -0500, Alan Stern wrote:
> On Wed, 9 Dec 2009, Stephen Rothwell wrote:
>
> > Hi Greg,
> >
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> >
> > drivers/net/usb/kaweth.c: In function 'kaweth_open':
> > drivers/net/usb/kaweth.c:719: error: implicit declaration of function 'usb_autopm_enable'
> >
> > Caused by commit b3f937e6ddf3e60ed9b4c26349b7b171dffdd010 ("USB: prepare
> > for changover to Runtime PM framework").
> >
> > I have reverted that commit for today.
>
> This should have been okay because of Oliver's patch:
>
> http://marc.info/?l=linux-netdev&m=125071045301270&w=2
>
> which removed the offending reference. Hasn't it been merged yet?
> It was submitted back in August.

Hm, I thought I saw this in David's network tree in linux-next, but
perhaps that was the wifi and one other patch, I didn't look for the
kaweth patch.

David, any ideas if the patch above was just dropped for some reason.
If it was just overlooked, I can take it through my tree, as I depend on
it to not break the build.

thanks,

greg k-h