2010-07-03 16:04:54

by Kulikov Vasiliy

Subject: [PATCH 19/19] drivers/usb/core: use for_each_pci_dev()

Use for_each_pci_dev() to simplify the code.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/usb/core/hcd-pci.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index 7e2d527..c1f0bba 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -66,10 +66,7 @@ static void companion_common(struct pci_dev *pdev, struct usb_hcd *hcd,
* vice versa.
*/
companion = NULL;
- for (;;) {
- companion = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, companion);
- if (!companion)
- break;
+ for_each_pci_dev(companion) {
if (companion->bus != pdev->bus ||
PCI_SLOT(companion->devfn) != slot)
continue;
--
1.7.0.4

2010-07-04 13:18:46

by Alan Stern

Subject: Re: [PATCH 19/19] drivers/usb/core: use for_each_pci_dev()

On Sat, 3 Jul 2010, Kulikov Vasiliy wrote:

> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> drivers/usb/core/hcd-pci.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
> index 7e2d527..c1f0bba 100644
> --- a/drivers/usb/core/hcd-pci.c
> +++ b/drivers/usb/core/hcd-pci.c
> @@ -66,10 +66,7 @@ static void companion_common(struct pci_dev *pdev, struct usb_hcd *hcd,
> * vice versa.
> */
> companion = NULL;
> - for (;;) {
> - companion = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, companion);
> - if (!companion)
> - break;
> + for_each_pci_dev(companion) {
> if (companion->bus != pdev->bus ||
> PCI_SLOT(companion->devfn) != slot)
> continue;

Acked-by: Alan Stern <[email protected]>