2012-06-04 19:20:30

by Roland Stigge

Subject: [PATCH] ohci-hub: Mark ohci_finish_controller_resume() as __maybe_unused

ohci_finish_controller_resume() is intended to be used in platform specific
drivers ohci-*.c, included from ohci-hcd.c. Some of them don't actually use
ohci_finish_controller_resume(), so mark it as __maybe_unused.

Signed-off-by: Roland Stigge <[email protected]>

---
drivers/usb/host/ohci-hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/drivers/usb/host/ohci-hub.c
+++ linux-2.6/drivers/usb/host/ohci-hub.c
@@ -317,7 +317,7 @@ static int ohci_bus_resume (struct usb_h
}

/* Carry out the final steps of resuming the controller device */
-static void ohci_finish_controller_resume(struct usb_hcd *hcd)
+static void __maybe_unused ohci_finish_controller_resume(struct usb_hcd *hcd)
{
struct ohci_hcd *ohci = hcd_to_ohci(hcd);
int port;

2012-06-04 20:16:55

by Alan Stern

Subject: Re: [PATCH] ohci-hub: Mark ohci_finish_controller_resume() as __maybe_unused

On Mon, 4 Jun 2012, Roland Stigge wrote:

> ohci_finish_controller_resume() is intended to be used in platform specific
> drivers ohci-*.c, included from ohci-hcd.c. Some of them don't actually use
> ohci_finish_controller_resume(), so mark it as __maybe_unused.
>
> Signed-off-by: Roland Stigge <[email protected]>

Acked-by: Alan Stern <[email protected]>

> ---
> drivers/usb/host/ohci-hub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.orig/drivers/usb/host/ohci-hub.c
> +++ linux-2.6/drivers/usb/host/ohci-hub.c
> @@ -317,7 +317,7 @@ static int ohci_bus_resume (struct usb_h
> }
>
> /* Carry out the final steps of resuming the controller device */
> -static void ohci_finish_controller_resume(struct usb_hcd *hcd)
> +static void __maybe_unused ohci_finish_controller_resume(struct usb_hcd *hcd)
> {
> struct ohci_hcd *ohci = hcd_to_ohci(hcd);
> int port;
>
>