2012-06-06 12:21:24

by Namjae Jeon

Subject: [PATCH 3/3] usb: core: update usb devices for write cache quirk in quirk list.

Update Product ID and Vendor ID of Segate Portable HDD and WD My Passport HDD in quirk list.

Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Pankaj Kumar <[email protected]>
Signed-off-by: Amit Sahrawat <[email protected]>
---
drivers/usb/core/quirks.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 32d3adc..624d111 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -153,6 +153,12 @@ static const struct usb_device_id usb_quirk_list[] = {
/* INTEL VALUE SSD */
{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },

+ /* Seagate Portable Hdd */
+ { USB_DEVICE(0x0BC2, 0x2300), .driver_info = USB_QUIRK_WRITE_CACHE },
+
+ /* My Passport Hdd (WD) */
+ { USB_DEVICE(0x1058, 0x070A), .driver_info = USB_QUIRK_WRITE_CACHE },
+
{ } /* terminating entry must be last */
};

--
1.7.9.5

2012-06-06 15:33:53

by Alan Stern

Subject: Re: [PATCH 3/3] usb: core: update usb devices for write cache quirk in quirk list.

On Wed, 6 Jun 2012, Namjae Jeon wrote:

> Update Product ID and Vendor ID of Segate Portable HDD and WD My Passport HDD in quirk list.
>
> Signed-off-by: Namjae Jeon <[email protected]>
> Signed-off-by: Pankaj Kumar <[email protected]>
> Signed-off-by: Amit Sahrawat <[email protected]>
> ---
> drivers/usb/core/quirks.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 32d3adc..624d111 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -153,6 +153,12 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* INTEL VALUE SSD */
> { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>
> + /* Seagate Portable Hdd */
> + { USB_DEVICE(0x0BC2, 0x2300), .driver_info = USB_QUIRK_WRITE_CACHE },
> +
> + /* My Passport Hdd (WD) */
> + { USB_DEVICE(0x1058, 0x070A), .driver_info = USB_QUIRK_WRITE_CACHE },
> +

These entries belong in drivers/usb/storage/unusual_devs.h, not here.

Alan Stern