2012-06-09 12:09:35

by Namjae Jeon

Subject: [PATCH v2 3/4] usb: storage: update usb devices for write cache quirk in quirk list.

Update information of Segate Portable HDD and WD My Passport HDD in
quirk list.

Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Pankaj Kumar <[email protected]>
Signed-off-by: Amit Sahrawat <[email protected]>
---
drivers/usb/storage/unusual_devs.h | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 1719886..1d895f4 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2025,6 +2025,16 @@ UNUSUAL_DEV( 0xed10, 0x7636, 0x0001, 0x0001,
"Digital MP3 Audio Player",
USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE ),

+UNUSUAL_DEV(0x1058, 0x070A, 0x0000, 0x9999,
+ "Western Digital",
+ "My Passport HDD",
+ USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
+UNUSUAL_DEV(0x0BC2, 0x2300, 0x0000, 0x9999,
+ "Seagate",
+ "Portable HDD",
+ USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
/* Control/Bulk transport for all SubClass values */
USUAL_DEV(USB_SC_RBC, USB_PR_CB, USB_US_TYPE_STOR),
USUAL_DEV(USB_SC_8020, USB_PR_CB, USB_US_TYPE_STOR),
--
1.7.9.5

2012-06-09 15:31:56

by Alan Stern

Subject: Re: [PATCH v2 3/4] usb: storage: update usb devices for write cache quirk in quirk list.

On Sat, 9 Jun 2012, Namjae Jeon wrote:

> Update information of Segate Portable HDD and WD My Passport HDD in
> quirk list.
>
> Signed-off-by: Namjae Jeon <[email protected]>
> Signed-off-by: Pankaj Kumar <[email protected]>
> Signed-off-by: Amit Sahrawat <[email protected]>
> ---
> drivers/usb/storage/unusual_devs.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 1719886..1d895f4 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2025,6 +2025,16 @@ UNUSUAL_DEV( 0xed10, 0x7636, 0x0001, 0x0001,
> "Digital MP3 Audio Player",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE ),
>
> +UNUSUAL_DEV(0x1058, 0x070A, 0x0000, 0x9999,
> + "Western Digital",
> + "My Passport HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
> +
> +UNUSUAL_DEV(0x0BC2, 0x2300, 0x0000, 0x9999,
> + "Seagate",
> + "Portable HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
> +

Entries must be sorted by Vendor ID and then Product ID. Please put
your new entries in the correct spot.

Alan Stern

2012-06-09 16:52:50

by Namjae Jeon

Subject: Re: [PATCH v2 3/4] usb: storage: update usb devices for write cache quirk in quirk list.

2012/6/9 Alan Stern <[email protected]>:
> On Sat, 9 Jun 2012, Namjae Jeon wrote:
>
>> Update information of Segate Portable HDD and WD My Passport HDD in
>> quirk list.
>>
>> Signed-off-by: Namjae Jeon <[email protected]>
>> Signed-off-by: Pankaj Kumar <[email protected]>
>> Signed-off-by: Amit Sahrawat <[email protected]>
>> ---
>>  drivers/usb/storage/unusual_devs.h |   10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
>> index 1719886..1d895f4 100644
>> --- a/drivers/usb/storage/unusual_devs.h
>> +++ b/drivers/usb/storage/unusual_devs.h
>> @@ -2025,6 +2025,16 @@ UNUSUAL_DEV( 0xed10, 0x7636, 0x0001, 0x0001,
>>               "Digital MP3 Audio Player",
>>               USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE ),
>>
>> +UNUSUAL_DEV(0x1058, 0x070A, 0x0000, 0x9999,
>> +             "Western Digital",
>> +             "My Passport HDD",
>> +             USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
>> +
>> +UNUSUAL_DEV(0x0BC2, 0x2300, 0x0000, 0x9999,
>> +             "Seagate",
>> +             "Portable HDD",
>> +             USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
>> +
>
> Entries must be sorted by Vendor ID and then Product ID.  Please put
> your new entries in the correct spot.
Okay, I will resend th patch after moving code.
Thanks.
>
> Alan Stern
>

2012-06-09 17:27:44

by Bart Van Assche

Subject: Re: [PATCH v2 3/4] usb: storage: update usb devices for write cache quirk in quirk list.

On 06/09/12 12:09, Namjae Jeon wrote:

> Update information of Segate Portable HDD and WD My Passport HDD in
> quirk list.


Segate or Seagate ?

Bart.

2012-06-09 17:29:57

by Namjae Jeon

Subject: Re: [PATCH v2 3/4] usb: storage: update usb devices for write cache quirk in quirk list.

2012/6/9 Bart Van Assche <[email protected]>:
> On 06/09/12 12:09, Namjae Jeon wrote:
>
>> Update information of Segate Portable HDD and WD My Passport HDD in
>> quirk list.
>
>
> Segate or Seagate ?
Seagate is right. I will change.
Thanks~
>
> Bart.