Hi there.
This is a series of 6 patches that remove the old, deprecated power
management interface from a variety of old OSS drivers, most of them
marked OBSOLETE and scheduled for removal in January 2006.
These patches facilitate the removal of the ancient PM interface by
reducing the number of in-kernel users to 3:
drivers/net/3c509.c
drivers/net/irda/ali-ircc.c
drivers/serial/68328serial.c
Of the drivers affected by these patches, the following are marked
OBSOLETE:
- cs4281
- cs46xx
- maestro
- nm256
The following is not, though there seems to be a corresponding ALSA
driver:
- opl3sa2
The ad1848 driver is used by several OSS drivers. This may be the most
controversial removal.
Does any one have any objections to these patches?
Thanks,
Pat
Patrick Mochel:
[OSS] Remove deprecated PM interface from ad1848 driver.
[OSS] Remove deprecated PM interface from cs4281 driver.
[OSS] Remove deprecated PM interface from cs46xx driver.
[OSS] Remove deprecated PM interface from maestrodriver.
[OSS] Remove deprecated PM interface from nm256 driver.
[OSS] Remove deprecated PM interface from opl3sa2driver.
sound/oss/ad1848.c | 92 -------------------------
sound/oss/cs4281/cs4281m.c | 21 -----
sound/oss/cs4281/cs4281pm-24.c | 39 ----------
sound/oss/cs46xx.c | 60 ----------------
sound/oss/cs46xxpm-24.h | 4 -
sound/oss/maestro.c | 149 -----------------------------------------
sound/oss/nm256_audio.c | 47 ------------
sound/oss/opl3sa2.c | 110 ------------------------------
8 files changed, 1 insertion(+), 521 deletions(-)
On Wed, Nov 23, 2005 at 12:23:25PM -0800, Patrick Mochel wrote:
>
> Hi there.
Hi Patrick,
> This is a series of 6 patches that remove the old, deprecated power
> management interface from a variety of old OSS drivers, most of them
> marked OBSOLETE and scheduled for removal in January 2006.
>
> These patches facilitate the removal of the ancient PM interface by
> reducing the number of in-kernel users to 3:
>
> drivers/net/3c509.c
> drivers/net/irda/ali-ircc.c
> drivers/serial/68328serial.c
>...
> Does any one have any objections to these patches?
I'd say the obsolete OSS drivers are the least problem, it would be more
interesting to get the code fixed that will still be present two months
from now.
Looking at the current state of 2.6.15, I doubt your patches would make
it into Linus' tree earlier than the complete removal of the drivers.
> Thanks,
>
> Pat
>...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Wed, 23 Nov 2005, Adrian Bunk wrote:
> On Wed, Nov 23, 2005 at 12:23:25PM -0800, Patrick Mochel wrote:
> >
> > Hi there.
>
> Hi Patrick,
>
> > This is a series of 6 patches that remove the old, deprecated power
> > management interface from a variety of old OSS drivers, most of them
> > marked OBSOLETE and scheduled for removal in January 2006.
> >
> > These patches facilitate the removal of the ancient PM interface by
> > reducing the number of in-kernel users to 3:
> >
> > drivers/net/3c509.c
> > drivers/net/irda/ali-ircc.c
> > drivers/serial/68328serial.c
> >...
> > Does any one have any objections to these patches?
>
> I'd say the obsolete OSS drivers are the least problem, it would be more
> interesting to get the code fixed that will still be present two months
> from now.
I completely agree. I just wanted to start some place easy. :)
> Looking at the current state of 2.6.15, I doubt your patches would make
> it into Linus' tree earlier than the complete removal of the drivers.
That's a good point. I'll not worry about pushing the patches that affect
these to-be-removed drivers.
Thanks,
Patrick
Hi!
> This is a series of 6 patches that remove the old, deprecated power
> management interface from a variety of old OSS drivers, most of them
> marked OBSOLETE and scheduled for removal in January 2006.
It may be nice to develop some macros/tricks to convert those into
platform devices quickly. This would actually have chance of not
breaking suspend/resume on affected drivers. (Not that it matters for
these).
Pavel
--
Thanks, Sharp!