2006-02-21 00:55:46

by Patrick Mochel

Subject: [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in).

Signed-off-by: Patrick Mochel <[email protected]>

---

include/linux/pm.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

applies-to: 55ce8c6305fc70b1b544ce7365abd6054e9b5f61
7af37561812f4599841ade4abee067b808b40054
diff --git a/include/linux/pm.h b/include/linux/pm.h
index 5be87ba..a7324ea 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -140,6 +140,7 @@ struct device;

typedef struct pm_message {
int event;
+ u32 state;
} pm_message_t;

/*
---
0.99.9.GIT

2006-02-21 18:35:23

by Greg KH

Subject: Re: [PATCH 1/4] [pm] Add state filed to pm_message_t (to hold actual state device is in).

On Mon, Feb 20, 2006 at 04:55:37PM -0800, Patrick Mochel wrote:
>
> Signed-off-by: Patrick Mochel <[email protected]>
>
> ---
>
> include/linux/pm.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> applies-to: 55ce8c6305fc70b1b544ce7365abd6054e9b5f61
> 7af37561812f4599841ade4abee067b808b40054
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index 5be87ba..a7324ea 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -140,6 +140,7 @@ struct device;
>
> typedef struct pm_message {
> int event;
> + u32 state;

Can we _please_ make this an enumerated type that is able to be
type-checked by sparse? A "raw" u32 is not a good thing to have here.

thanks,

greg k-h