2002-11-28 07:19:52

by Pawel Bernadowski

Subject: error in quirks.c

I use 2.5.50 and always get this error
gcc -Wp,-MD,drivers/pci/.quirks.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686
-Iarch/i386/mach-generic -nostdinc -iwithprefix include
-DKBUILD_BASENAME=quirks -DKBUILD_MODNAME=quirks -c -o
drivers/pci/quirks.o drivers/pci/quirks.c
drivers/pci/quirks.c: In function `quirk_ioapic_rmw':
drivers/pci/quirks.c:354: `sis_apic_bug' undeclared (first use in this
function)
drivers/pci/quirks.c:354: (Each undeclared identifier is reported only
once
drivers/pci/quirks.c:354: for each function it appears in.)

2002-11-28 09:28:44

by Alex Riesen

Subject: Re: error in quirks.c

On Thu, Nov 28, 2002 at 08:27:09AM +0100, Pawel Bernadowski wrote:
> I use 2.5.50 and always get this error
> gcc -Wp,-MD,drivers/pci/.quirks.o.d -D__KERNEL__ -Iinclude -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
> -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686
> -Iarch/i386/mach-generic -nostdinc -iwithprefix include
> -DKBUILD_BASENAME=quirks -DKBUILD_MODNAME=quirks -c -o
> drivers/pci/quirks.o drivers/pci/quirks.c
> drivers/pci/quirks.c: In function `quirk_ioapic_rmw':
> drivers/pci/quirks.c:354: `sis_apic_bug' undeclared (first use in this

You have IO-APIC enabled.
Alan posted a similar patch somewhere before, just in case here is the fix
for quirks.c:


--- 2.5.50+bk/drivers/pci/quirks.c 2002-11-26 06:03:51.000000000 +0100
+++ 2.5.50/drivers/pci/quirks.c 2002-11-28 10:29:37.000000000 +0100
@@ -350,6 +350,7 @@

static void __init quirk_ioapic_rmw(struct pci_dev *dev)
{
+ extern int sis_apic_bug;
if (dev->devfn == 0 && dev->bus->number == 0)
sis_apic_bug = 1;
}