2003-02-16 18:59:34

by Matthew Wilcox

[permalink] [raw]
Subject: [PATCH] [RESEND 6] sysctls for PA-RISC


Can anyone think why Linus isn't applying this patch? He won't tell
me what's wrong with it, and I'm getting frustrated by the silence.

Add two new sysctls. The first one handles the soft-power switch
and the second describes what to do when we get an unaligned trap.

--- linus-2.5/include/linux/sysctl.h Sun Jan 5 11:03:43 2003
+++ parisc-2.5/include/linux/sysctl.h Sun Jan 5 11:23:43 2003
@@ -129,6 +129,8 @@ enum
KERN_CADPID=54, /* int: PID of the process to notify on CAD */
KERN_PIDMAX=55, /* int: PID # limit */
KERN_CORE_PATTERN=56, /* string: pattern for core-file names */
+ KERN_HPPA_PWRSW=57, /* int: hppa soft-power enable */
+ KERN_HPPA_UNALIGNED=58, /* int: hppa unaligned-trap enable */
};


--- linus-2.5/kernel/sysctl.c Sun Jan 5 11:03:50 2003
+++ parisc-2.5/kernel/sysctl.c Sun Jan 5 11:23:55 2003
@@ -84,6 +84,11 @@ extern char reboot_command [];
extern int stop_a_enabled;
#endif

+#ifdef __hppa__
+extern int pwrsw_enabled;
+extern int unaligned_enabled;
+#endif
+
#ifdef CONFIG_ARCH_S390
#ifdef CONFIG_MATHEMU
extern int sysctl_ieee_emulation_warnings;
@@ -188,6 +193,12 @@ static ctl_table kern_table[] = {
{KERN_SPARC_REBOOT, "reboot-cmd", reboot_command,
256, 0644, NULL, &proc_dostring, &sysctl_string },
{KERN_SPARC_STOP_A, "stop-a", &stop_a_enabled, sizeof (int),
+ 0644, NULL, &proc_dointvec},
+#endif
+#ifdef __hppa__
+ {KERN_HPPA_PWRSW, "soft-power", &pwrsw_enabled, sizeof (int),
+ 0644, NULL, &proc_dointvec},
+ {KERN_HPPA_UNALIGNED, "unaligned-trap", &unaligned_enabled, sizeof (int),
0644, NULL, &proc_dointvec},
#endif
#if defined(CONFIG_PPC32) && defined(CONFIG_6xx)

--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk


2003-02-17 01:32:42

by Rik van Riel

[permalink] [raw]
Subject: Re: [PATCH] [RESEND 6] sysctls for PA-RISC

On Sun, 16 Feb 2003, Matthew Wilcox wrote:

> Can anyone think why Linus isn't applying this patch?

Not a clue, the only thing I can think of is that Linus might
like other people to look at the patch before applying it...

Linus, Matthew's patch only adds some (PA-RISC conditional)
sysctls to the kernel and is otherwise harmless. Safe to apply.

cheers,

Rik
--
Bravely reimplemented by the knights who say "NIH".
http://www.surriel.com/ http://guru.conectiva.com/
Current spamtrap: <a href=mailto:"[email protected]">[email protected]</a>

2003-02-17 11:29:34

by Russell King

[permalink] [raw]
Subject: Re: [PATCH] [RESEND 6] sysctls for PA-RISC

On Sun, Feb 16, 2003 at 10:42:17PM -0300, Rik van Riel wrote:
> On Sun, 16 Feb 2003, Matthew Wilcox wrote:
> > Can anyone think why Linus isn't applying this patch?
>
> Not a clue, the only thing I can think of is that Linus might
> like other people to look at the patch before applying it...

FYI, Linus hasn't taken my set of (BK) changes yet, so I don't think
there's anything specific (anti-BK or otherwise) about not taking
patches at the moment.

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html

2003-02-21 21:22:53

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] [RESEND 6] sysctls for PA-RISC

Hi!

> Can anyone think why Linus isn't applying this patch? He won't tell
> me what's wrong with it, and I'm getting frustrated by the silence.
>
> Add two new sysctls. The first one handles the soft-power switch
> and the second describes what to do when we get an unaligned trap.

Perhaps that soft-power thingie should be done in a generic way? Any
modern pc has soft-power, too...
Pavel

> --- linus-2.5/include/linux/sysctl.h Sun Jan 5 11:03:43 2003
> +++ parisc-2.5/include/linux/sysctl.h Sun Jan 5 11:23:43 2003
> @@ -129,6 +129,8 @@ enum
> KERN_CADPID=54, /* int: PID of the process to notify on CAD */
> KERN_PIDMAX=55, /* int: PID # limit */
> KERN_CORE_PATTERN=56, /* string: pattern for core-file names */
> + KERN_HPPA_PWRSW=57, /* int: hppa soft-power enable */
> + KERN_HPPA_UNALIGNED=58, /* int: hppa unaligned-trap enable */
> };
>
>
> --- linus-2.5/kernel/sysctl.c Sun Jan 5 11:03:50 2003
> +++ parisc-2.5/kernel/sysctl.c Sun Jan 5 11:23:55 2003
> @@ -84,6 +84,11 @@ extern char reboot_command [];
> extern int stop_a_enabled;
> #endif
>
> +#ifdef __hppa__
> +extern int pwrsw_enabled;
> +extern int unaligned_enabled;
> +#endif
> +
> #ifdef CONFIG_ARCH_S390
> #ifdef CONFIG_MATHEMU
> extern int sysctl_ieee_emulation_warnings;
> @@ -188,6 +193,12 @@ static ctl_table kern_table[] = {
> {KERN_SPARC_REBOOT, "reboot-cmd", reboot_command,
> 256, 0644, NULL, &proc_dostring, &sysctl_string },
> {KERN_SPARC_STOP_A, "stop-a", &stop_a_enabled, sizeof (int),
> + 0644, NULL, &proc_dointvec},
> +#endif
> +#ifdef __hppa__
> + {KERN_HPPA_PWRSW, "soft-power", &pwrsw_enabled, sizeof (int),
> + 0644, NULL, &proc_dointvec},
> + {KERN_HPPA_UNALIGNED, "unaligned-trap", &unaligned_enabled, sizeof (int),
> 0644, NULL, &proc_dointvec},
> #endif
> #if defined(CONFIG_PPC32) && defined(CONFIG_6xx)
>

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]