2003-06-10 13:41:33

by Maciej Soltysiak

[permalink] [raw]
Subject: [PATCHLET] 2.5.70 invalid icmp broadcast.

Hello,

I noticed this a couple of weeks ago in the kernel log:
150.254.39.135 sent an invalid to a broadcast.

I decided to make the kernel be more verbose about it. Here is a patch
that would show:
150.254.39.135 sent an invalid ICMP type 11, code 0 error to a broadcast: 150.254.39.255 on eth1

Please apply.

Regards,
Maciej

diff -Nru linux-2.5.68.bak/net/ipv4/icmp.c linux-2.5.70/net/ipv4/icmp.c
--- linux-2.5.68.bak/net/ipv4/icmp.c 2003-05-17 14:56:11.000000000 +0200
+++ linux-2.5.70/net/ipv4/icmp.c 2003-06-09 13:21:37.000000000 +0200
@@ -663,8 +659,12 @@
inet_addr_type(iph->daddr) == RTN_BROADCAST) {
if (net_ratelimit())
printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP "
- "error to a broadcast.\n",
- NIPQUAD(skb->nh.iph->saddr));
+ "type %u, code %u "
+ "error to a broadcast: %u.%u.%u.%u on %s\n",
+ NIPQUAD(iph->saddr),
+ icmph->type, icmph->code,
+ NIPQUAD(iph->daddr),
+ skb->dev->name);
goto out;
}