2003-06-06 14:04:00

by John Kim

Subject: make allyesconfig broken in 2.5.70-bk10 and -bk11

make allyesconfig hangs just after displaying the following:

<-- SNIP -->
*
* Security options
*
Enable different security models (SECURITY) [N/y/?] (NEW) y
Socket and Networking Security Hooks (SECURITY_NETWORK) [N/y/?] (NEW) y
Default Linux Capabilities (SECURITY_CAPABILITIES) [N/m/y/?] (NEW) y
Root Plug Support (SECURITY_ROOTPLUG) [N/m/y/?] (NEW) y
*
* Cryptographic options
*
-----
make allyesconfig works just fine for -bk9.

John Kim

2003-06-06 14:51:35

by Roman Zippel

Subject: Re: make allyesconfig broken in 2.5.70-bk10 and -bk11

Hi,

On Fri, 6 Jun 2003, John Kim wrote:

> Root Plug Support (SECURITY_ROOTPLUG) [N/m/y/?] (NEW) y
> *
> * Cryptographic options
> *
> -----
> make allyesconfig works just fine for -bk9.

Hmm, it seems I missed a problem with the new select keyword.
This patch prevents any attempt to change any symbol which isn't changable
anyway (e.g. force to 'y' via select).

bye, Roman

diff -pur linux-2.5.70-bk10.org/scripts/kconfig/conf.c linux-2.5.70-bk10/scripts/kconfig/conf.c
--- linux-2.5.70-bk10.org/scripts/kconfig/conf.c 2003-06-06 10:57:49.000000000 +0200
+++ linux-2.5.70-bk10/scripts/kconfig/conf.c 2003-06-06 16:51:38.000000000 +0200
@@ -73,6 +73,13 @@ static void conf_askvalue(struct symbol
line[0] = '\n';
line[1] = 0;

+ if (!sym_is_changable(sym)) {
+ printf("%s\n", def);
+ line[0] = '\n';
+ line[1] = 0;
+ return;
+ }
+
switch (input_mode) {
case ask_new:
case ask_silent:
@@ -82,12 +89,6 @@ static void conf_askvalue(struct symbol
}
check_stdin();
case ask_all:
- if (!sym_is_changable(sym)) {
- printf("%s\n", def);
- line[0] = '\n';
- line[1] = 0;
- return;
- }
fflush(stdout);
fgets(line, 128, stdin);
return;