Hi Christoph,
I'm building without quota support. I get the following error at link
time:
fs/fs.o(.text..SHmedia32+0x33fa0): In function `v1_get_stats':
: undefined reference to `dqstats'
fs/fs.o(.text..SHmedia32+0x33fa4): In function `v1_get_stats':
: undefined reference to `dqstats'
make: *** [vmlinux] Error 1
Looking in fs/Makefile, fs/quota.c it's apparent that quota.o is being
included unconditionally in the link now, and quota.c references
dqstats, but dqstats is defined in fs/dquot.c which is only linked in if
CONFIG_QUOTA is set.
I'm sorry I'm not familiar enough with this area of the code to suggest
a fix.
Cheers
Richard
--
Richard \\\ SuperH Core+Debug Architect /// .. At home ..
P. /// [email protected] /// [email protected]
Curnow \\\ http://www.superh.com/ /// http://www.rc0.org.uk
I'm waiting from a hch's patch to fix that and have -pre4 released
tomorrow.
On Tue, 8 Jul 2003, Richard Curnow wrote:
> Hi Christoph,
>
> I'm building without quota support. I get the following error at link
> time:
>
> fs/fs.o(.text..SHmedia32+0x33fa0): In function `v1_get_stats':
> : undefined reference to `dqstats'
> fs/fs.o(.text..SHmedia32+0x33fa4): In function `v1_get_stats':
> : undefined reference to `dqstats'
> make: *** [vmlinux] Error 1
>
> Looking in fs/Makefile, fs/quota.c it's apparent that quota.o is being
> included unconditionally in the link now, and quota.c references
> dqstats, but dqstats is defined in fs/dquot.c which is only linked in if
> CONFIG_QUOTA is set.
>
> I'm sorry I'm not familiar enough with this area of the code to suggest
> a fix.
>
> Cheers
> Richard
>
> --
> Richard \\\ SuperH Core+Debug Architect /// .. At home ..
> P. /// [email protected] /// [email protected]
> Curnow \\\ http://www.superh.com/ /// http://www.rc0.org.uk
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
On Tue, Jul 08, 2003 at 10:21:28AM +0100, Richard Curnow wrote:
> Hi Christoph,
>
> I'm building without quota support. I get the following error at link
> time:
This is the patch I sent to marcelo a few minutes ago:
===== fs/dquot.c 1.18 vs edited =====
--- 1.18/fs/dquot.c Tue Jun 24 23:11:29 2003
+++ edited/fs/dquot.c Mon Jul 7 10:44:36 2003
@@ -152,8 +152,6 @@
static LIST_HEAD(free_dquots);
static struct list_head dquot_hash[NR_DQHASH];
-struct dqstats dqstats;
-
static void dqput(struct dquot *);
static struct dquot *dqduplicate(struct dquot *);
===== fs/quota.c 1.1 vs edited =====
--- 1.1/fs/quota.c Tue Jun 24 23:11:30 2003
+++ edited/fs/quota.c Mon Jul 7 10:42:58 2003
@@ -13,6 +13,7 @@
#include <linux/smp_lock.h>
#include <linux/quotacompat.h>
+struct dqstats dqstats;
/* Check validity of quotactl */
static int check_quotactl_valid(struct super_block *sb, int type, int cmd, qid_t id)
* Christoph Hellwig <[email protected]> [2003-07-08]:
> On Tue, Jul 08, 2003 at 10:21:28AM +0100, Richard Curnow wrote:
> > Hi Christoph,
> >
> > I'm building without quota support. I get the following error at link
> > time:
>
> This is the patch I sent to marcelo a few minutes ago:
Thanks, looks good, I'll pick this up when we 'bk pull' next time. As a
workaround I've been compiling today with quota support turned on :-)
--
Richard \\\ SuperH Core+Debug Architect /// .. At home ..
P. /// [email protected] /// [email protected]
Curnow \\\ http://www.superh.com/ /// http://www.rc0.org.uk