2004-06-30 02:41:16

by Eric Lammerts

[permalink] [raw]
Subject: [PATCH] asiliantfb fixes


Hi,
this patch fixes the asiliantfb driver. A call to the init function
was missing so it was never actually used. The other fix is in the
init function writing somewhere using a physical address instead of a
virtual address.

Eric

--- linux-2.6.7/drivers/video/fbmem.c.orig 2004-06-23 21:53:18.000000000 -0400
+++ linux-2.6.7/drivers/video/fbmem.c 2004-06-28 22:10:45.000000000 -0400
@@ -172,6 +172,7 @@
extern int kyrofb_setup(char*);
extern int mc68x328fb_init(void);
extern int mc68x328fb_setup(char *);
+extern int asiliantfb_init(void);

static struct {
const char *name;
@@ -245,6 +246,9 @@
#ifdef CONFIG_FB_CT65550
{ "chipsfb", chips_init, NULL },
#endif
+#ifdef CONFIG_FB_ASILIANT
+ { "asiliant", asiliantfb_init, NULL },
+#endif
#ifdef CONFIG_FB_IMSTT
{ "imsttfb", imsttfb_init, imsttfb_setup },
#endif
--- linux-2.6.7/drivers/video/asiliantfb.c.orig 2004-06-28 22:03:38.000000000 -0400
+++ linux-2.6.7/drivers/video/asiliantfb.c 2004-06-28 22:04:28.000000000 -0400
@@ -571,7 +571,7 @@
}

pci_write_config_dword(dp, 4, 0x02800083);
- writeb(3, addr + 0x400784);
+ writeb(3, p->screen_base + 0x400784);

init_asiliant(p, addr);


2004-06-30 03:18:14

by Paul Mundt

[permalink] [raw]
Subject: Re: [PATCH] asiliantfb fixes

On Tue, Jun 29, 2004 at 10:41:12PM -0400, Eric Lammerts wrote:
> this patch fixes the asiliantfb driver. A call to the init function
> was missing so it was never actually used. The other fix is in the
> init function writing somewhere using a physical address instead of a
> virtual address.
>
The asiliantfb_init() stuff is already fixed in current BK.


Attachments:
(No filename) (357.00 B)
(No filename) (189.00 B)
Download all attachments

2004-06-30 11:52:54

by jsimmons

[permalink] [raw]
Subject: Re: [PATCH] asiliantfb fixes


The below fix is missing. It needs to be applied.

--- linux-2.6.7/drivers/video/asiliantfb.c.orig 2004-06-28
22:03:38.000000000 -0400
+++ linux-2.6.7/drivers/video/asiliantfb.c 2004-06-28
22:04:28.000000000 -0400
@@ -571,7 +571,7 @@
}

pci_write_config_dword(dp, 4, 0x02800083);
- writeb(3, addr + 0x400784);
+ writeb(3, p->screen_base + 0x400784);

init_asiliant(p, addr);


On Tue, 29 Jun 2004, Paul Mundt wrote:

> On Tue, Jun 29, 2004 at 10:41:12PM -0400, Eric Lammerts wrote:
> > this patch fixes the asiliantfb driver. A call to the init function
> > was missing so it was never actually used. The other fix is in the
> > init function writing somewhere using a physical address instead of a
> > virtual address.
> >
> The asiliantfb_init() stuff is already fixed in current BK.
>
>

2004-06-30 13:07:26

by Paul Mundt

[permalink] [raw]
Subject: Re: [PATCH] asiliantfb fixes

On Wed, Jun 30, 2004 at 12:52:49PM +0100, [email protected] wrote:
>
> The below fix is missing. It needs to be applied.
>

Yes, this still needs to be merged. Can you roll this into your next
batch of fb updates? If not, I'll pass it along, unless Andrew decides to
merge this directly.

> --- linux-2.6.7/drivers/video/asiliantfb.c.orig 2004-06-28
> 22:03:38.000000000 -0400
> +++ linux-2.6.7/drivers/video/asiliantfb.c 2004-06-28
> 22:04:28.000000000 -0400
> @@ -571,7 +571,7 @@
> }
>
> pci_write_config_dword(dp, 4, 0x02800083);
> - writeb(3, addr + 0x400784);
> + writeb(3, p->screen_base + 0x400784);
>
> init_asiliant(p, addr);
>


Attachments:
(No filename) (701.00 B)
(No filename) (189.00 B)
Download all attachments