2005-11-02 09:11:06

by Adrian Bunk

Subject: [2.6 patch] drivers/block/pktcdvd.c: remove write-only variable in pkt_iosched_process_queue()

Found this on Coverty's linux bug database (http://linuxbugsdb.coverity.com).

The function pkt_iosched_process_queue makes a call to bdev_get_queue and stores the result but never uses it, so
it looks like it can be safely removed.

From: Gabriel A. Devenyi <[email protected]>

Signed-off-by: Gabriel A. Devenyi <[email protected]>
Signed-off-by: Adrian Bunk <[email protected]>

--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -501,14 +501,11 @@ static void pkt_queue_bio(struct pktcdvd
*/
static void pkt_iosched_process_queue(struct pktcdvd_device *pd)
{
- request_queue_t *q;

if (atomic_read(&pd->iosched.attention) == 0)
return;
atomic_set(&pd->iosched.attention, 0);

- q = bdev_get_queue(pd->bdev);
-
for (;;) {
struct bio *bio;
int reads_queued, writes_queued;

2005-11-04 15:39:27

by Peter Osterlund

Subject: Re: [2.6 patch] drivers/block/pktcdvd.c: remove write-only variable in pkt_iosched_process_queue()

On Wed, 2 Nov 2005, Adrian Bunk wrote:

> Found this on Coverty's linux bug database (http://linuxbugsdb.coverity.com).
>
> The function pkt_iosched_process_queue makes a call to bdev_get_queue
> and stores the result but never uses it, so it looks like it can be
> safely removed.
>
> From: Gabriel A. Devenyi <[email protected]>

Thanks. The patch looks good.

--
Peter Osterlund - [email protected]
http://web.telia.com/~u89404340