Function prototypes belong into header files.
Signed-off-by: Adrian Bunk <[email protected]>
---
fs/hfsplus/hfsplus_fs.h | 3 +++
fs/hfsplus/inode.c | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.15-rc2-mm1-full/fs/hfsplus/hfsplus_fs.h.old 2005-11-23 16:36:41.000000000 +0100
+++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/hfsplus_fs.h 2005-11-23 16:37:19.000000000 +0100
@@ -347,6 +347,9 @@
void hfsplus_fill_defaults(struct hfsplus_sb_info *);
int hfsplus_show_options(struct seq_file *, struct vfsmount *);
+/* super.c */
+void hfsplus_inode_check(struct super_block *sb);
+
/* tables.c */
extern u16 hfsplus_case_fold_table[];
extern u16 hfsplus_decompose_table[];
--- linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c.old 2005-11-23 16:37:34.000000000 +0100
+++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c 2005-11-23 16:37:48.000000000 +0100
@@ -183,7 +183,6 @@
hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
mark_inode_dirty(inode);
{
- void hfsplus_inode_check(struct super_block *sb);
atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
hfsplus_inode_check(sb);
}
@@ -322,7 +321,6 @@
return NULL;
{
- void hfsplus_inode_check(struct super_block *sb);
atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
hfsplus_inode_check(sb);
}
On Wed, 23 Nov 2005, Adrian Bunk wrote:
> Function prototypes belong into header files.
I'd like to see someone fix kernel/power/disk.c also....
--
~Randy
On Wed, Nov 23, 2005 at 02:50:05PM -0800, Randy.Dunlap wrote:
> On Wed, 23 Nov 2005, Adrian Bunk wrote:
>
> > Function prototypes belong into header files.
>
> I'd like to see someone fix kernel/power/disk.c also....
This will also be done before I'll submit my patch to add
-Wmissing-prototypes to the global CFLAGS - but I can't fix all places
in the kernel at the same day, there are too many of them...
> ~Randy
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Wed, 23 Nov 2005, Adrian Bunk wrote:
> On Wed, Nov 23, 2005 at 02:50:05PM -0800, Randy.Dunlap wrote:
> > On Wed, 23 Nov 2005, Adrian Bunk wrote:
> >
> > > Function prototypes belong into header files.
> >
> > I'd like to see someone fix kernel/power/disk.c also....
>
> This will also be done before I'll submit my patch to add
> -Wmissing-prototypes to the global CFLAGS - but I can't fix all places
> in the kernel at the same day, there are too many of them...
Of course, I didn't expect them to be fixed in one day
or even for you to be the only person who may do it.
Thanks,
--
~Randy