Hi Philippe,
On Fri, 13 Apr 2007, Philippe De Muyter wrote:
> Add support for the Motorola sysv68 disk partition table (slices in motorola
> doc).
>
> Signed-off-by: Philippe De Muyter <[email protected]>
>
> diff -r 1b54f1d81bc5 fs/partitions/Kconfig
> --- a/fs/partitions/Kconfig Thu Apr 12 15:44:52 2007 -0700
> +++ b/fs/partitions/Kconfig Fri Apr 13 15:51:58 2007 +0200
> @@ -236,3 +236,12 @@ config EFI_PARTITION
> help
> Say Y here if you would like to use hard disks under Linux which
> were partitioned using EFI GPT.
> +
> +config SYSV68_PARTITION
> + bool "SYSV68 partition table support" if PARTITION_ADVANCED
> + default y if M68K
^^^^^^^^^^^^^^^^^
> + help
> + Say Y here if you would like to be able to read the hard disk
> + partition table format used by Motorola Delta machines (using
> + sysv68).
> + Otherwise, say N.
Bummer, I saw your patch before, but I never noticed the `default y if M68K'.
Can you please tell me on which platforms SYSV68 partition tables are commonly
used (I guess the Motorola MVME boards?), so we can enable it by default on a
more sensible subset of M68K?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
On Tue, May 08, 2007 at 10:21:12PM +0200, Geert Uytterhoeven wrote:
> Hi Philippe,
>
> On Fri, 13 Apr 2007, Philippe De Muyter wrote:
> > Add support for the Motorola sysv68 disk partition table (slices in motorola
> > doc).
> >
> > Signed-off-by: Philippe De Muyter <[email protected]>
> >
> > diff -r 1b54f1d81bc5 fs/partitions/Kconfig
> > --- a/fs/partitions/Kconfig Thu Apr 12 15:44:52 2007 -0700
> > +++ b/fs/partitions/Kconfig Fri Apr 13 15:51:58 2007 +0200
> > @@ -236,3 +236,12 @@ config EFI_PARTITION
> > help
> > Say Y here if you would like to use hard disks under Linux which
> > were partitioned using EFI GPT.
> > +
> > +config SYSV68_PARTITION
> > + bool "SYSV68 partition table support" if PARTITION_ADVANCED
> > + default y if M68K
> ^^^^^^^^^^^^^^^^^
> > + help
> > + Say Y here if you would like to be able to read the hard disk
> > + partition table format used by Motorola Delta machines (using
> > + sysv68).
> > + Otherwise, say N.
>
> Bummer, I saw your patch before, but I never noticed the `default y if M68K'.
>
> Can you please tell me on which platforms SYSV68 partition tables are commonly
> used (I guess the Motorola MVME boards?), so we can enable it by default on a
The Motorola VME boards are the only ones I am aware of. I must also add
that the partitions themselves are sysv partitions.
> more sensible subset of M68K?
Feel free to replace or suppress the `default' directive. I actually wrote
that for a i586 laptop to access/reinstall disks of sysV68 machines using
a USB/SCSI adapter, but I don't think `default y' is a good idea :).
What do you think of
`default y if VME'
or
`default y if M68K && SYSV_FS'
Best regards
Philippe
On Wed, 9 May 2007, Philippe De Muyter wrote:
> On Tue, May 08, 2007 at 10:21:12PM +0200, Geert Uytterhoeven wrote:
> > On Fri, 13 Apr 2007, Philippe De Muyter wrote:
> > > Add support for the Motorola sysv68 disk partition table (slices in motorola
> > > doc).
> > >
> > > Signed-off-by: Philippe De Muyter <[email protected]>
> > >
> > > diff -r 1b54f1d81bc5 fs/partitions/Kconfig
> > > --- a/fs/partitions/Kconfig Thu Apr 12 15:44:52 2007 -0700
> > > +++ b/fs/partitions/Kconfig Fri Apr 13 15:51:58 2007 +0200
> > > @@ -236,3 +236,12 @@ config EFI_PARTITION
> > > help
> > > Say Y here if you would like to use hard disks under Linux which
> > > were partitioned using EFI GPT.
> > > +
> > > +config SYSV68_PARTITION
> > > + bool "SYSV68 partition table support" if PARTITION_ADVANCED
> > > + default y if M68K
> > ^^^^^^^^^^^^^^^^^
> > > + help
> > > + Say Y here if you would like to be able to read the hard disk
> > > + partition table format used by Motorola Delta machines (using
> > > + sysv68).
> > > + Otherwise, say N.
> >
> > Bummer, I saw your patch before, but I never noticed the `default y if M68K'.
> >
> > Can you please tell me on which platforms SYSV68 partition tables are commonly
> > used (I guess the Motorola MVME boards?), so we can enable it by default on a
>
> The Motorola VME boards are the only ones I am aware of. I must also add
> that the partitions themselves are sysv partitions.
>
> > more sensible subset of M68K?
>
> Feel free to replace or suppress the `default' directive. I actually wrote
> that for a i586 laptop to access/reinstall disks of sysV68 machines using
> a USB/SCSI adapter, but I don't think `default y' is a good idea :).
>
> What do you think of
> `default y if VME'
> or
> `default y if M68K && SYSV_FS'
I prefer `default y if VME'.
BTW, perhaps PPC based Motorola MVME boards use SYSV68 partition tables,
too?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
> > What do you think of
> > `default y if VME'
> > or
> > `default y if M68K && SYSV_FS'
>
> I prefer `default y if VME'.
>
> BTW, perhaps PPC based Motorola MVME boards use SYSV68 partition tables,
> too?
No, the PPC based Motorola MVME boards use the (currently not supported by
linux) AIX partition tables, as do also the motorola powerstack machines.
The m88k based Motorola MVME boards use the sysV68 partition tables, but
m88k is not yet supported by linux.
Incidentally, what is the problem you have with SYSV68_PARTITION ?
On my i586 machine, code size is 434 bytes for sysv68.o + 4 bytes more in
check.c
Philippe
On Tue, May 08, 2007 at 10:21:12PM +0200, Geert Uytterhoeven wrote:
> Hi Philippe,
> On Fri, 13 Apr 2007, Philippe De Muyter wrote:
> > Add support for the Motorola sysv68 disk partition table (slices in motorola
> > doc).
> >
> > Signed-off-by: Philippe De Muyter <[email protected]>
> >
> > diff -r 1b54f1d81bc5 fs/partitions/Kconfig
> > --- a/fs/partitions/Kconfig Thu Apr 12 15:44:52 2007 -0700
> > +++ b/fs/partitions/Kconfig Fri Apr 13 15:51:58 2007 +0200
> > @@ -236,3 +236,12 @@ config EFI_PARTITION
> > help
> > Say Y here if you would like to use hard disks under Linux which
> > were partitioned using EFI GPT.
> > +
> > +config SYSV68_PARTITION
> > + bool "SYSV68 partition table support" if PARTITION_ADVANCED
> > + default y if M68K
> ^^^^^^^^^^^^^^^^^
> > + help
> > + Say Y here if you would like to be able to read the hard disk
> > + partition table format used by Motorola Delta machines (using
> > + sysv68).
> > + Otherwise, say N.
>
> Bummer, I saw your patch before, but I never noticed the `default y if M68K'.
>
> Can you please tell me on which platforms SYSV68 partition tables are commonly
> used (I guess the Motorola MVME boards?),
I guess so. I have a disk for my MVME167 lying around here somewhere
with SYSV/68 on it. If you want, I can verify what exact machines it
runs on, but I guess "every 68k MVME" is a safe enough bet.
--
Shaw's Principle:
Build a system that even a fool can use, and only a fool will
want to use it.
> > > `default y if M68K && SYSV_FS'
> >
> > I prefer `default y if VME'.
> >
>
> Incidentally, what is the problem you have with SYSV68_PARTITION ?
> On my i586 machine, code size is 434 bytes for sysv68.o + 4 bytes more in
> check.c
Traditionally, we have always been very conservative about enabling more
than the absolute minimum in partition format support. Some formats can be
erroneously identified by the check code if you don't get the ordering
right (the case I know about, MSDOS partitions vs. Atari TOS/GEM
partitions, hinges on a particular checksum being calculated in the atari
code). I've moved the msdos checker to the bottom of the list more often
than I can keep track of...
If sysv68 cannot be confused with any other format, no harm done by
enabling it by default. Otherwise, things may get interesting.
Michael
Don't enable SYSV68 partition table support on all m68k boxes by default,
only on Motorola VME boards.
Signed-off-by: Geert Uytterhoeven <[email protected]>
Cc: Philippe De Muyter <[email protected]>
---
fs/partitions/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-m68k-2.6.21.orig/fs/partitions/Kconfig
+++ linux-m68k-2.6.21/fs/partitions/Kconfig
@@ -239,7 +239,7 @@ config EFI_PARTITION
config SYSV68_PARTITION
bool "SYSV68 partition table support" if PARTITION_ADVANCED
- default y if M68K
+ default y if VME
help
Say Y here if you would like to be able to read the hard disk
partition table format used by Motorola Delta machines (using
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds