2007-05-05 16:36:28

by Niklas Steinkamp

Subject: DC390: replace pci_module_init in dc390_module_init

Hi,

while compiling the DC930 SCSI driver, i got this message:

drivers/built-in.o: In function `dc390_module_init':
tmscsim.c:(.init.text+0x124c4): undefined reference to `pci_module_init'
make: *** [.tmp_vmlinux1] Fehler 1

so i replaced "pci_module_init" with "pci_register_device"
and it works just fine.
--------------------------

diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index a583e89..3158949 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
printk (KERN_INFO "DC390: Using safe settings.\n");
}

- return pci_module_init(&dc390_driver);
+ return pci_register_driver(&dc390_driver);
}

static void __exit dc390_module_exit(void)

2007-05-05 20:23:22

by Guennadi Liakhovetski

Subject: Re: DC390: replace pci_module_init in dc390_module_init

On Sat, 5 May 2007, Niklas Steinkamp wrote:

> while compiling the DC930 SCSI driver, i got this message:
>
> drivers/built-in.o: In function `dc390_module_init':
> tmscsim.c:(.init.text+0x124c4): undefined reference to `pci_module_init'
> make: *** [.tmp_vmlinux1] Fehler 1
>
> so i replaced "pci_module_init" with "pci_register_device"
> and it works just fine.
> --------------------------
>
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
> index a583e89..3158949 100644
> --- a/drivers/scsi/tmscsim.c
> +++ b/drivers/scsi/tmscsim.c
> @@ -2680,7 +2680,7 @@ static int __init dc390_module_init(void)
> printk (KERN_INFO "DC390: Using safe settings.\n");
> }
>
> - return pci_module_init(&dc390_driver);
> + return pci_register_driver(&dc390_driver);
> }
>
> static void __exit dc390_module_exit(void)

Thanks for the patch, but this is already fixed in -mm tree:
http://marc.info/?l=linux-scsi&m=117757368229767&w=2

Thanks
Guennadi
---
Guennadi Liakhovetski