2005-03-03 13:41:50

by Jan Engelhardt

[permalink] [raw]
Subject: pci_find_class obsolete

Hello list,


after switching to 2.6.11-rc5-bk2 (from 2.6.9-rc2), I found that the nvidia
module (1.0-4996, old, I know) does not compile anymore, because it
requires pci_find_class():

nv.c:
static int
nvos_probe_devices(void)
{
...
struct pci_dev *dev;
...
dev = pci_find_class(PCI_CLASS_DISPLAY_VGA << 8, dev);
...
}

What function would I need to use, now that pci_find_class is gone?


Jan Engelhardt
--


2005-03-03 14:19:58

by Matthias-Christian Ott

[permalink] [raw]
Subject: Re: pci_find_class obsolete

Jan Engelhardt wrote:

>Hello list,
>
>
>after switching to 2.6.11-rc5-bk2 (from 2.6.9-rc2), I found that the nvidia
>module (1.0-4996, old, I know) does not compile anymore, because it
>requires pci_find_class():
>
>nv.c:
>static int
>nvos_probe_devices(void)
>{
> ...
> struct pci_dev *dev;
> ...
> dev = pci_find_class(PCI_CLASS_DISPLAY_VGA << 8, dev);
> ...
>}
>
>What function would I need to use, now that pci_find_class is gone?
>
>
>Jan Engelhardt
>
>
Hi!
you have to use pci_get_class (). But have a look at the patches for
6111 on my webiste:

http://unixforge.org/~matthias-christian-ott/index.php?entry=entry050303-082233

Matthias-Christian Ott

2005-03-03 16:07:37

by Jan Engelhardt

[permalink] [raw]
Subject: Re: pci_find_class obsolete


>> What function would I need to use, now that pci_find_class is gone?

> Hi!
> you have to use pci_get_class (). But have a look at the patches for 6111
> on my webiste:

I use 4996 because it uses four times less kernel memory than 6111. (And on
top, 6111 does not give me any performance improvements over 4996.)

> http://unixforge.org/~matthias-christian-ott/index.php?entry=entry050303-082233
What's the patch doing?

I do not use AGPGART/DRI - no performance plus either.



Jan Engelhardt
--