2005-09-14 06:50:23

by Karel Kulhavy

Subject: Search in make menuconfig doesn't work properly

I have 2.6.13 and if I press '/' in make menuconfig (Search
Configuration Parameter, Enter Keyword) and enther "emulation", it
doesn't find
CONFIG_BLK_DEV_IDESCSI - SCSI emulation support.

CL<

2005-09-14 09:27:48

by Cal Peake

Subject: Re: Search in make menuconfig doesn't work properly

On Wed, 14 Sep 2005, Karel Kulhavy wrote:

> I have 2.6.13 and if I press '/' in make menuconfig (Search
> Configuration Parameter, Enter Keyword) and enther "emulation", it
> doesn't find
> CONFIG_BLK_DEV_IDESCSI - SCSI emulation support.

AFAIK it only matches against the CONFIG_ symbols. If you want it to do
more cook up a patch ;)

--
". . . tell 'em we use Linux." -- Dave Chappelle

2005-09-14 12:39:35

by Karel Kulhavy

Subject: Re: Search in make menuconfig doesn't work properly

On Wed, Sep 14, 2005 at 05:27:49AM -0400, Cal Peake wrote:
> On Wed, 14 Sep 2005, Karel Kulhavy wrote:
>
> > I have 2.6.13 and if I press '/' in make menuconfig (Search
> > Configuration Parameter, Enter Keyword) and enther "emulation", it
> > doesn't find
> > CONFIG_BLK_DEV_IDESCSI - SCSI emulation support.
>
> AFAIK it only matches against the CONFIG_ symbols. If you want it to do
> more cook up a patch ;)

I suggest "Enter Keyword" to be changed to "Enter Keyword to search
in CONFIG_... symbols".

CL<

2005-09-14 14:57:11

by Randy Dunlap

Subject: Re: Search in make menuconfig doesn't work properly

On Wed, 14 Sep 2005, Cal Peake wrote:

> On Wed, 14 Sep 2005, Karel Kulhavy wrote:
>
> > I have 2.6.13 and if I press '/' in make menuconfig (Search
> > Configuration Parameter, Enter Keyword) and enther "emulation", it
> > doesn't find
> > CONFIG_BLK_DEV_IDESCSI - SCSI emulation support.
>
> AFAIK it only matches against the CONFIG_ symbols. If you want it to do
> more cook up a patch ;)

IOW, entering:

/BLK_DEV_IDESCSI

does produce the expected (but maybe not the desired?) results.

WFM.
--
~Randy

2005-09-14 15:07:10

by Randy Dunlap

Subject: Re: Search in make menuconfig doesn't work properly

On Wed, 14 Sep 2005, Karel Kulhavy wrote:

> On Wed, Sep 14, 2005 at 05:27:49AM -0400, Cal Peake wrote:
> > On Wed, 14 Sep 2005, Karel Kulhavy wrote:
> >
> > > I have 2.6.13 and if I press '/' in make menuconfig (Search
> > > Configuration Parameter, Enter Keyword) and enther "emulation", it
> > > doesn't find
> > > CONFIG_BLK_DEV_IDESCSI - SCSI emulation support.
> >
> > AFAIK it only matches against the CONFIG_ symbols. If you want it to do
> > more cook up a patch ;)
>
> I suggest "Enter Keyword" to be changed to "Enter Keyword to search
> in CONFIG_... symbols".

Makes sense. or "Enter CONFIG_ symbol to search for: (omit CONFIG_)".

Please send a patch.

--
~Randy

2005-09-24 02:09:09

by Randy Dunlap

Subject: [PATCH] clarify menuconfig /(search) help text

From: Randy Dunlap <[email protected]>

Add explicit text about
- where menuconfig '/' (search) searches for strings,
- that substrings are allowed, and
- that regular expressions are supported.

Signed-off-by: Randy Dunlap <[email protected]>
---

scripts/kconfig/mconf.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)

diff -Naurp linux-2614-rc2-git3/scripts/kconfig/mconf.c~search_keyword linux-2614-rc2-git3/scripts/kconfig/mconf.c
--- linux-2614-rc2-git3/scripts/kconfig/mconf.c~search_keyword 2005-08-28 16:41:01.000000000 -0700
+++ linux-2614-rc2-git3/scripts/kconfig/mconf.c 2005-09-23 19:04:39.000000000 -0700
@@ -219,6 +219,7 @@ save_config_help[] = N_(
search_help[] = N_(
"\n"
"Search for CONFIG_ symbols and display their relations.\n"
+ "Regular expressions are allowed.\n"
"Example: search for \"^FOO\"\n"
"Result:\n"
"-----------------------------------------------------------------\n"
@@ -531,7 +532,7 @@ again:
cprint("--title");
cprint(_("Search Configuration Parameter"));
cprint("--inputbox");
- cprint(_("Enter Keyword"));
+ cprint(_("Enter CONFIG_ (sub)string to search for (omit CONFIG_)"));
cprint("10");
cprint("75");
cprint("");

---