2006-11-11 17:12:08

by Burman Yan

[permalink] [raw]
Subject: Proper patch posting question

Hi.

I made a patch that replaces kmalloc+memset with kzalloc. The changes are in
many
different places in the kernel, but most of them are trivial. The whole
patch is about
360Kb. The less trivial parts that make more changes than just replacing
kmalloc with
kzalloc and removing the memset are in different patches that I will send to
the proper
maintainers.
My question is what would be the right way to post the trivial changes?
The way I see, I have a few options:
1) Post the entire patch on lkml
2) Split the patch into subsystems and post the smaller parts on lkml
3) Send the patch to [email protected]

Thank you in advance
Yan Burman

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/


2006-11-11 18:21:21

by Jan Engelhardt

[permalink] [raw]
Subject: Re: Proper patch posting question


> I made a patch that replaces kmalloc+memset with kzalloc. The changes are in
> many
> different places in the kernel, but most of them are trivial. The whole patch
> is about
> 360Kb. The less trivial parts that make more changes than just replacing
> kmalloc with
> kzalloc and removing the memset are in different patches that I will send to
> the proper
> maintainers.
> My question is what would be the right way to post the trivial changes?
> The way I see, I have a few options:
> 1) Post the entire patch on lkml

Split by complexity, then by size (IIRC LKML allows up to 100 KB mails,
but keep it smaller preferably because when it gets tedious to look at a
mail, continue 'somewhere in the middle' is hard - find the spot first)

> 2) Split the patch into subsystems and post the smaller parts on lkml

Subsystems is also a good idea.

> 3) Send the patch to [email protected]

I'd go for lkml + trivial.


-`J'
--