Jesper Juhl <[email protected]> wrote:
> If Andrew agrees, then I'll commit to doing this cleanup;
> - (to a limited degree) no trailing whitespace
I just ran a script over -rc4 to remove trailing ws. The result is
about 22 MB in 429 patches (iterated over ./*/*).
How hard can I patch you before you start patching me?
Which addresses am I supposed to send it to? I don't want to break the
record for the most annoying patch series in lkml.
--
If at first you don't succeed, call it version 1.0
Bodo Eggert <[email protected]> wrote:
>Jesper Juhl <[email protected]> wrote:
>
>
>>If Andrew agrees, then I'll commit to doing this cleanup;
>>
>
>>- (to a limited degree) no trailing whitespace
>>
>
>I just ran a script over -rc4 to remove trailing ws. The result is
>about 22 MB in 429 patches (iterated over ./*/*).
>
>How hard can I patch you before you start patching me?
>
>Which addresses am I supposed to send it to? I don't want to break the
>record for the most annoying patch series in lkml.
>
First of all, why is it 429 patches? The patches we want aren't about a
file or a subdirectory or even a subsystem, but they're supposed to be
a logical change. Ie. 1 patch. An exception for something like this would
be if you want to feed it to different maintainers seperately, but it
sounds like you just want to bomb it somewhere...
Secondly, let's not.
More subtle indenting stuff like fixing `if (exp) do_something` I can
understand. But this isn't nearly so helpful.
On Thu, 12 May 2005, Nick Piggin wrote:
> Bodo Eggert <[email protected]> wrote:
> >Jesper Juhl <[email protected]> wrote:
> >>If Andrew agrees, then I'll commit to doing this cleanup;
> >>- (to a limited degree) no trailing whitespace
> >I just ran a script over -rc4 to remove trailing ws. The result is
> >about 22 MB in 429 patches (iterated over ./*/*).
> >
> >How hard can I patch you before you start patching me?
> >
> >Which addresses am I supposed to send it to? I don't want to break the
> >record for the most annoying patch series in lkml.
> >
>
> First of all, why is it 429 patches?
Because
1) some parts will get rejected due to conflicting patches. Only those
parts will need to be recreated.
2) i forgot to create the 430th patch.
> The patches we want aren't about a
> file or a subdirectory or even a subsystem, but they're supposed to be
> a logical change. Ie. 1 patch.
That would be too large for most mailboxes. If you like a single patch,
you can just concatenate all the patches, so splitting it was a safe bet.
> An exception for something like this would
> be if you want to feed it to different maintainers seperately, but it
> sounds like you just want to bomb it somewhere...
I asume there is no automatic way to get the maintainer from a given
file, and I don't want to grow old and grey while doing that manually.
--
"Bravery is being the only one who knows you're afraid."
-David Hackworth
On Thu, 12 May 2005, Bodo Eggert <[email protected]> wrote:
> Date: Thu, 12 May 2005 01:47:28 +0200
> From: "Bodo Eggert <[email protected]>"
> <[email protected]>
> To: Jesper Juhl <[email protected]>, David S.Miller <[email protected]>,
> Andrew Morton <[email protected]>, [email protected]
> Subject: Re: [PATCH] kernel/module.c has something to hide. (whitespace
> cleanup)
>
> Jesper Juhl <[email protected]> wrote:
>
> > If Andrew agrees, then I'll commit to doing this cleanup;
>
> > - (to a limited degree) no trailing whitespace
>
> I just ran a script over -rc4 to remove trailing ws. The result is
> about 22 MB in 429 patches (iterated over ./*/*).
>
Ok, I'm not looking at trailing ws yet. I'm working on the "two statements
on one line" and "spaces between function name and opening paren" bits.
It's a bit slow going since I don't have many hours a day untill the
weekend, but I hope to have the first batch of patches ready over the
weekend.
> How hard can I patch you before you start patching me?
>
Let me have a copy of your patches, then I can do my work incremental to
yours. If you could tar & gz them and attach them to a mail and send it
to me in private email that would be perfect.
/Jesper
Jesper Juhl <[email protected]> wrote:
>
> Ok, I'm not looking at trailing ws yet.
Obviously the way to handle this is to write a script and send it to Linus.
Good luck ;)