On Tue, Sep 06, 2005 at 04:08:56AM -0700, Andrew Morton wrote:
>
> Problem Description:
>
> Oops: 0000 [#1]
> PREEMPT
> Modules linked in:
> CPU: 0
> EIP: 0060:[<c01f562c>] Not tainted VLI
> EFLAGS: 00010216 (2.6.13)
> EIP is at sha1_update+0x7c/0x160
Thanks for the report. Matt LaPlante had exactly the same problem
a couple of days ago. I've tracked down now to my broken crypto
cipher wrapper functions which will step over a page boundary if
it's not aligned correctly.
[CRYPTO] Fix boundary check in standard multi-block cipher processors
The boundary check in the standard multi-block cipher processors are
broken when nbytes is not a multiple of bsize. In those cases it will
always process an extra block.
This patch corrects the check so that it processes at most nbytes of data.
Signed-off-by: Herbert Xu <[email protected]>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Tue, 6 Sep 2005, Herbert Xu wrote:
> On Tue, Sep 06, 2005 at 04:08:56AM -0700, Andrew Morton wrote:
>>
>> Problem Description:
>>
>> Oops: 0000 [#1]
>> PREEMPT
>> Modules linked in:
>> CPU: 0
>> EIP: 0060:[<c01f562c>] Not tainted VLI
>> EFLAGS: 00010216 (2.6.13)
>> EIP is at sha1_update+0x7c/0x160
>
> Thanks for the report. Matt LaPlante had exactly the same problem
> a couple of days ago. I've tracked down now to my broken crypto
> cipher wrapper functions which will step over a page boundary if
> it's not aligned correctly.
>
>
> [CRYPTO] Fix boundary check in standard multi-block cipher processors
Thanks. Patched my kernel, recompiled and waiting. So far it is OK,
Should this patch be merged into 2.6.13.1?
Best regards,
Krzysztof Ol?dzki
Patch worked like a charm here, no more kernel panics! Excellent work, many
thanks for the quick fix...more people should have such a work ethic.
Cheers,
Matt
> -----Original Message-----
> From: [email protected] [mailto:linux-kernel-
> [email protected]] On Behalf Of Herbert Xu
> Sent: Tuesday, September 06, 2005 8:20 AM
> To: Andrew Morton
> Cc: [email protected]; [email protected]; bugme-daemon@kernel-
> bugs.osdl.org; Matt LaPlante; Linux Kernel Mailing List; David S. Miller
> Subject: Re: Fw: [Bugme-new] [Bug 5194] New: IPSec related OOps in 2.6.13
>
> On Tue, Sep 06, 2005 at 04:08:56AM -0700, Andrew Morton wrote:
> >
> > Problem Description:
> >
> > Oops: 0000 [#1]
> > PREEMPT
> > Modules linked in:
> > CPU: 0
> > EIP: 0060:[<c01f562c>] Not tainted VLI
> > EFLAGS: 00010216 (2.6.13)
> > EIP is at sha1_update+0x7c/0x160
>
> Thanks for the report. Matt LaPlante had exactly the same problem
> a couple of days ago. I've tracked down now to my broken crypto
> cipher wrapper functions which will step over a page boundary if
> it's not aligned correctly.
>
>
> [CRYPTO] Fix boundary check in standard multi-block cipher processors
>
> The boundary check in the standard multi-block cipher processors are
> broken when nbytes is not a multiple of bsize. In those cases it will
> always process an extra block.
>
> This patch corrects the check so that it processes at most nbytes of data.
>
> Signed-off-by: Herbert Xu <[email protected]>
>
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Tue, 6 Sep 2005, Herbert Xu wrote:
> On Tue, Sep 06, 2005 at 04:08:56AM -0700, Andrew Morton wrote:
>>
>> Problem Description:
>>
>> Oops: 0000 [#1]
>> PREEMPT
>> Modules linked in:
>> CPU: 0
>> EIP: 0060:[<c01f562c>] Not tainted VLI
>> EFLAGS: 00010216 (2.6.13)
>> EIP is at sha1_update+0x7c/0x160
>
> Thanks for the report. Matt LaPlante had exactly the same problem
> a couple of days ago. I've tracked down now to my broken crypto
> cipher wrapper functions which will step over a page boundary if
> it's not aligned correctly.
This bug is resolved. I believe we can close it.
Best regards,
Krzysztof Ol?dzki