2007-02-15 15:06:29

by Geert Uytterhoeven

Subject: [PATCH] do_basic_setup: implicit declaration of function ‘init_irq_proc'

Add missing #include <linux/irq.h>, which caused

| init/main.c: In function ‘do_basic_setup’:
| init/main.c:705: warning: implicit declaration of function ‘init_irq_proc’

Signed-off-by: Geert Uytterhoeven <[email protected]>

diff --git a/init/main.c b/init/main.c
index 2421e15..8bba00e 100644
--- a/init/main.c
+++ b/init/main.c
@@ -52,6 +52,7 @@
#include <linux/lockdep.h>
#include <linux/pid_namespace.h>
#include <linux/device.h>
+#include <linux/irq.h>

#include <asm/io.h>
#include <asm/bugs.h>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
[email protected] ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

2007-02-15 22:14:02

by Andrew Morton

Subject: Re: [PATCH] do_basic_setup: implicit declaration of function ‘init_irq_proc'

On Thu, 15 Feb 2007 16:06:23 +0100 (CET)
Geert Uytterhoeven <[email protected]> wrote:

> Add missing #include <linux/irq.h>, which caused
>
> | init/main.c: In function ‘do_basic_setup’:
> | init/main.c:705: warning: implicit declaration of function ‘init_irq_proc’
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> diff --git a/init/main.c b/init/main.c
> index 2421e15..8bba00e 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -52,6 +52,7 @@
> #include <linux/lockdep.h>
> #include <linux/pid_namespace.h>
> #include <linux/device.h>
> +#include <linux/irq.h>
>

Russell will chuck a wobbly: `head -10 include/linux/irq.h'

Probably the init_irq_proc() declaration is in the wrong header.