2006-01-17 14:02:31

by Rui Saraiva

[permalink] [raw]
Subject: [PATCH 2.6.15+]: Trusted Platform depends on Security models


It seems that "TPM Hardware Support" (CONFIG_TCG_TPM) depends on
"Enable different security models" (CONFIG_SECURITY). Without this last
option, I get:

$ make modules_install
. . .
if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map 2.6.16-rc1; fi
WARNING: /lib/modules/2.6.16-rc1/kernel/drivers/char/tpm/tpm_bios.ko needs unknown symbol securityfs_create_dir
WARNING: /lib/modules/2.6.16-rc1/kernel/drivers/char/tpm/tpm_bios.ko needs unknown symbol securityfs_remove
WARNING: /lib/modules/2.6.16-rc1/kernel/drivers/char/tpm/tpm_bios.ko needs unknown symbol securityfs_create_file
$

Regards,

Signed-off-by: Rui Saraiva <[email protected]>

---

--- linux-2.6.16-rc1/drivers/char/Kconfig 2006-01-17 13:36:14.000000000 +0000
+++ linux-2.6.16-rc1-rmps/drivers/char/Kconfig 2006-01-17 13:36:43.000000000 +0000
@@ -6,7 +6,7 @@ menu "TPM devices"

config TCG_TPM
tristate "TPM Hardware Support"
- depends on EXPERIMENTAL
+ depends on EXPERIMENTAL && SECURITY
---help---
If you have a TPM security chip in your system, which
implements the Trusted Computing Group's specification,


2006-01-17 17:01:14

by Jerome Pinot

[permalink] [raw]
Subject: Re: [PATCH][2.6.16-rc1] TPM: tpm_bios needs securityfs (CONFIG_SECURITY)

Hi,

>It seems that "TPM Hardware Support" (CONFIG_TCG_TPM) depends on
>"Enable different security models" (CONFIG_SECURITY).

This does the trick but your patch formatting is broken. This one
applies cleanly against 2.6.16-rc1.

from: Rui Saraiva

tpm_bios (CONFIG_TCG_TPM) depends on securityfs (CONFIG_SECURITY).

Signed-off-by: Rui Saraiva <[email protected]>
Signed-off-by: Jerome Pinot <[email protected]>

---
diff -Naur a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
--- a/drivers/char/tpm/Kconfig 2006-01-17 16:12:37.000000000 +0000
+++ b/drivers/char/tpm/Kconfig 2006-01-17 16:13:05.000000000 +0000
@@ -6,7 +6,7 @@

config TCG_TPM
tristate "TPM Hardware Support"
- depends on EXPERIMENTAL
+ depends on EXPERIMENTAL && SECURITY
---help---
If you have a TPM security chip in your system, which
implements the Trusted Computing Group's specification,

2006-01-17 17:25:47

by Kylene Jo Hall

[permalink] [raw]
Subject: Re: [PATCH][2.6.16-rc1] TPM: tpm_bios needs securityfs (CONFIG_SECURITY)

Ack'ed-by: Kylene Hall <[email protected]>

On Wed, 2006-01-18 at 02:00 +0900, Jerome Pinot wrote:
> Hi,
>
> >It seems that "TPM Hardware Support" (CONFIG_TCG_TPM) depends on
> >"Enable different security models" (CONFIG_SECURITY).
>
> This does the trick but your patch formatting is broken. This one
> applies cleanly against 2.6.16-rc1.
>
> from: Rui Saraiva
>
> tpm_bios (CONFIG_TCG_TPM) depends on securityfs (CONFIG_SECURITY).
>
> Signed-off-by: Rui Saraiva <[email protected]>
> Signed-off-by: Jerome Pinot <[email protected]>
>
> ---
> diff -Naur a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> --- a/drivers/char/tpm/Kconfig 2006-01-17 16:12:37.000000000 +0000
> +++ b/drivers/char/tpm/Kconfig 2006-01-17 16:13:05.000000000 +0000
> @@ -6,7 +6,7 @@
>
> config TCG_TPM
> tristate "TPM Hardware Support"
> - depends on EXPERIMENTAL
> + depends on EXPERIMENTAL && SECURITY
> ---help---
> If you have a TPM security chip in your system, which
> implements the Trusted Computing Group's specification,
>
>

2006-01-22 07:39:10

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH][2.6.16-rc1] TPM: tpm_bios needs securityfs (CONFIG_SECURITY)

Kylene Jo Hall <[email protected]> wrote:
>
> Ack'ed-by: Kylene Hall <[email protected]>
>
> On Wed, 2006-01-18 at 02:00 +0900, Jerome Pinot wrote:
> > Hi,
> >
> > >It seems that "TPM Hardware Support" (CONFIG_TCG_TPM) depends on
> > >"Enable different security models" (CONFIG_SECURITY).
> >
> > This does the trick but your patch formatting is broken. This one
> > applies cleanly against 2.6.16-rc1.
> >
> > from: Rui Saraiva
> >
> > tpm_bios (CONFIG_TCG_TPM) depends on securityfs (CONFIG_SECURITY).
> >
> > Signed-off-by: Rui Saraiva <[email protected]>
> > Signed-off-by: Jerome Pinot <[email protected]>

No, this patch shouldn't be needed once we have the suitable security stubs
in place.

See
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm2/broken-out/tpm_bios-needs-more-securityfs_-functions.patch
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm2/broken-out/tpm_bios-securityfs-error-checking-fix.patch