2006-05-01 20:21:38

by Petri T. Koistinen

Subject: [PATCH] fs/isofs/namei.c: fix warnings of uninitialized variables

From: Petri T. Koistinen <[email protected]>

Remove warnings by initializing uninitialized variables.

Signed-off-by: Petri T. Koistinen <[email protected]>
---
fs/isofs/namei.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

---
diff --git a/fs/isofs/namei.c b/fs/isofs/namei.c
index e7ba0c3..e0d6531 100644
--- a/fs/isofs/namei.c
+++ b/fs/isofs/namei.c
@@ -159,7 +159,7 @@ isofs_find_entry(struct inode *dir, stru
struct dentry *isofs_lookup(struct inode * dir, struct dentry * dentry, struct nameidata *nd)
{
int found;
- unsigned long block, offset;
+ unsigned long block = 0, offset = 0;
struct inode *inode;
struct page *page;

2006-05-02 11:19:35

by Pekka Enberg

Subject: Re: [PATCH] fs/isofs/namei.c: fix warnings of uninitialized variables

On 5/1/06, Petri T. Koistinen <[email protected]> wrote:
> From: Petri T. Koistinen <[email protected]>
>
> Remove warnings by initializing uninitialized variables.
>
> Signed-off-by: Petri T. Koistinen <[email protected]>
> ---
> fs/isofs/namei.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> ---
> diff --git a/fs/isofs/namei.c b/fs/isofs/namei.c
> index e7ba0c3..e0d6531 100644
> --- a/fs/isofs/namei.c
> +++ b/fs/isofs/namei.c
> @@ -159,7 +159,7 @@ isofs_find_entry(struct inode *dir, stru
> struct dentry *isofs_lookup(struct inode * dir, struct dentry * dentry, struct nameidata *nd)
> {
> int found;
> - unsigned long block, offset;
> + unsigned long block = 0, offset = 0;

NAK. Both are initialized by isofs_find_entry() before being used.

Pekka