2006-08-18 21:02:15

by Cal Peake

Subject: [PATCH] kill extraneous printk in kernel_restart()

Hi,

Is there a reason for printing a single dot and newline in
kernel_restart()? If not, below is a one-liner to kill it.

thanks,
- C.

--

Get rid of an extraneous printk in kernel_restart().

Signed-off-by: Cal Peake <[email protected]>

--- linux-2.6.18-rc4/kernel/sys.c~orig 2006-08-07 22:00:27.000000000 -0400
+++ linux-2.6.18-rc4/kernel/sys.c 2006-08-18 16:52:52.000000000 -0400
@@ -611,7 +611,6 @@ void kernel_restart(char *cmd)
} else {
printk(KERN_EMERG "Restarting system with command '%s'.\n", cmd);
}
- printk(".\n");
machine_restart(cmd);
}
EXPORT_SYMBOL_GPL(kernel_restart);

2006-08-19 03:41:28

by Eric W. Biederman

Subject: Re: [PATCH] kill extraneous printk in kernel_restart()

Cal Peake <[email protected]> writes:

> Hi,
>
> Is there a reason for printing a single dot and newline in
> kernel_restart()? If not, below is a one-liner to kill it.

Hmm. This looks like a thinko from my original patch.

Signed-off-By: Eric W. Biederman <[email protected]>

> --
>
> Get rid of an extraneous printk in kernel_restart().
>
> Signed-off-by: Cal Peake <[email protected]>
>
> --- linux-2.6.18-rc4/kernel/sys.c~orig 2006-08-07 22:00:27.000000000 -0400
> +++ linux-2.6.18-rc4/kernel/sys.c 2006-08-18 16:52:52.000000000 -0400
> @@ -611,7 +611,6 @@ void kernel_restart(char *cmd)
> } else {
> printk(KERN_EMERG "Restarting system with command '%s'.\n", cmd);
> }
> - printk(".\n");
> machine_restart(cmd);
> }
> EXPORT_SYMBOL_GPL(kernel_restart);