In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
color scheme was changed to bluetitle. This breaks the highlighting
of the selected item for me with TERM=vt100. The only way I can see
which item is selected is via:
make MENUCONFIG_COLOR=mono menuconfig
Which restores the pre-2.6.19 white on black highlighting.
Sam?
Phil
Hallo.
Phil Oester wrote:
> In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
> color scheme was changed to bluetitle. This breaks the highlighting
> of the selected item for me with TERM=vt100. The only way I can see
> which item is selected is via:
>
> make MENUCONFIG_COLOR=mono menuconfig
>
> Which restores the pre-2.6.19 white on black highlighting.
Classic theme also doesn't work, and this commit doesn't look like
changing anything in it.
Thus, i think, just export variable with working theme (mono) on your
exotic setup.
> Sam?
If you want answer from busy developers, try to add their e-mail next
time.
> Phil
____
On Tue, Nov 14, 2006 at 08:16:33AM +0000, Oleg Verych wrote:
> Phil Oester wrote:
> > In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
> > color scheme was changed to bluetitle. This breaks the highlighting
> > of the selected item for me with TERM=vt100. The only way I can see
> > which item is selected is via:
> >
> > make MENUCONFIG_COLOR=mono menuconfig
> >
> > Which restores the pre-2.6.19 white on black highlighting.
>
> Classic theme also doesn't work, and this commit doesn't look like
> changing anything in it.
>
> Thus, i think, just export variable with working theme (mono) on your
> exotic setup.
Hmm...vt100 is exotic? If only you'd told me that 20 years ago ;-)
> > Sam?
>
> If you want answer from busy developers, try to add their e-mail next
> time.
Thanks for the tip.
Phil
Hi,
On Mon, 13 Nov 2006, Phil Oester wrote:
> In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
> color scheme was changed to bluetitle. This breaks the highlighting
> of the selected item for me with TERM=vt100. The only way I can see
> which item is selected is via:
>
> make MENUCONFIG_COLOR=mono menuconfig
>
> Which restores the pre-2.6.19 white on black highlighting.
Could you try the patch below?
bye, Roman
---
scripts/kconfig/lxdialog/util.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
Index: linux-2.6-mm/scripts/kconfig/lxdialog/util.c
===================================================================
--- linux-2.6-mm.orig/scripts/kconfig/lxdialog/util.c
+++ linux-2.6-mm/scripts/kconfig/lxdialog/util.c
@@ -221,16 +221,14 @@ static void init_dialog_colors(void)
*/
static void color_setup(const char *theme)
{
- if (set_theme(theme)) {
- if (has_colors()) { /* Terminal supports color? */
- start_color();
- init_dialog_colors();
- }
- }
- else
- {
+ int use_color;
+
+ use_color = set_theme(theme);
+ if (use_color && has_colors()) {
+ start_color();
+ init_dialog_colors();
+ } else
set_mono_theme();
- }
}
/*
On Tue, Nov 21, 2006 at 12:36:10AM +0100, Roman Zippel wrote:
> Could you try the patch below?
>
> bye, Roman
Yes, that restores the menu highlighting. Thanks Roman.
Phil