2006-12-10 11:37:42

by Cal Peake

Subject: [PATCH] include/linux/freezer.h needs PF_FREEZE and PF_FROZEN declarations

JFS (modular, if it matters) fails to build with this error:

In file included from fs/jfs/jfs_txnmgr.c:49:
include/linux/freezer.h: In function `frozen':
include/linux/freezer.h:9: error: dereferencing pointer to incomplete type
include/linux/freezer.h:9: error: `PF_FROZEN' undeclared (first use in this function)
include/linux/freezer.h:9: error: (Each undeclared identifier is reported only once
include/linux/freezer.h:9: error: for each function it appears in.)
...


From: Cal Peake <[email protected]>

Include include/linux/sched.h in include/linux/freezer.h for PF_FREEZE and
PF_FROZEN declarations.

Signed-off-by: Cal Peake <[email protected]>

--- ./include/linux/freezer.h~orig 2006-12-07 22:33:46.000000000 -0500
+++ ./include/linux/freezer.h 2006-12-10 06:15:11.000000000 -0500
@@ -1,6 +1,9 @@
/* Freezer declarations */

#ifdef CONFIG_PM
+
+#include <linux/sched.h>
+
/*
* Check if a process has been frozen
*/

2006-12-10 17:35:03

by Dave Kleikamp

Subject: Re: [PATCH] include/linux/freezer.h needs PF_FREEZE and PF_FROZEN declarations

On Sun, 2006-12-10 at 06:37 -0500, Cal Peake wrote:
> JFS (modular, if it matters) fails to build with this error:
>
> In file included from fs/jfs/jfs_txnmgr.c:49:
> include/linux/freezer.h: In function `frozen':
> include/linux/freezer.h:9: error: dereferencing pointer to incomplete type
> include/linux/freezer.h:9: error: `PF_FROZEN' undeclared (first use in this function)
> include/linux/freezer.h:9: error: (Each undeclared identifier is reported only once
> include/linux/freezer.h:9: error: for each function it appears in.)
> ...
>
>
> From: Cal Peake <[email protected]>
>
> Include include/linux/sched.h in include/linux/freezer.h for PF_FREEZE and
> PF_FROZEN declarations.
>
> Signed-off-by: Cal Peake <[email protected]>

Randy Dunlap has already submitted a patch to fix this:
http://marc.theaimsgroup.com/?l=linux-kernel&m=116555878318822&w=2

>
> --- ./include/linux/freezer.h~orig 2006-12-07 22:33:46.000000000 -0500
> +++ ./include/linux/freezer.h 2006-12-10 06:15:11.000000000 -0500
> @@ -1,6 +1,9 @@
> /* Freezer declarations */
>
> #ifdef CONFIG_PM
> +
> +#include <linux/sched.h>
> +
> /*
> * Check if a process has been frozen
> */

Thanks,
Shaggy
--
David Kleikamp
IBM Linux Technology Center