2007-02-21 15:05:37

by Peter Zijlstra

Subject: [PATCH 09/29] selinux: tag avc cache alloc as non-critical

Failing to allocate a cache entry will only harm performance.

Signed-off-by: Peter Zijlstra <[email protected]>
---
security/selinux/avc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-git/security/selinux/avc.c
===================================================================
--- linux-2.6-git.orig/security/selinux/avc.c 2007-02-14 08:31:13.000000000 +0100
+++ linux-2.6-git/security/selinux/avc.c 2007-02-14 10:10:47.000000000 +0100
@@ -332,7 +332,7 @@ static struct avc_node *avc_alloc_node(v
{
struct avc_node *node;

- node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC);
+ node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC);
if (!node)
goto out;


--

2007-02-21 15:22:59

by James Morris

Subject: Re: [PATCH 09/29] selinux: tag avc cache alloc as non-critical

On Wed, 21 Feb 2007, Peter Zijlstra wrote:

> Failing to allocate a cache entry will only harm performance.
>
> Signed-off-by: Peter Zijlstra <[email protected]>
> ---
> security/selinux/avc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: James Morris <[email protected]>

>
> Index: linux-2.6-git/security/selinux/avc.c
> ===================================================================
> --- linux-2.6-git.orig/security/selinux/avc.c 2007-02-14 08:31:13.000000000 +0100
> +++ linux-2.6-git/security/selinux/avc.c 2007-02-14 10:10:47.000000000 +0100
> @@ -332,7 +332,7 @@ static struct avc_node *avc_alloc_node(v
> {
> struct avc_node *node;
>
> - node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC);
> + node = kmem_cache_zalloc(avc_node_cachep, GFP_ATOMIC|__GFP_NOMEMALLOC);
> if (!node)
> goto out;
>
>
>

--
James Morris
<[email protected]>