2007-05-04 13:31:41

by Satyam Sharma

[permalink] [raw]
Subject: [PATCH] drivers/scsi/aic7xxx_old.c: remove redundant GFP_ATOMIC from kmalloc

drivers/scsi/aic7xxx_old.c:aic7xxx_slave_alloc() unnecessarily passes
GFP_ATOMIC (along with GFP_KERNEL) to kmalloc() from a context that is not
atomic. Remove the pointless GFP_ATOMIC.

Signed-off-by: Satyam Sharma <[email protected]>

---

diff -ruNp linux-2.6.21.1/drivers/scsi/aic7xxx_old.c linux-2.6.21.1~patch/drivers/scsi/aic7xxx_old.c
--- linux-2.6.21.1/drivers/scsi/aic7xxx_old.c 2007-04-26 08:38:32.000000000 +0530
+++ linux-2.6.21.1~patch/drivers/scsi/aic7xxx_old.c 2007-05-04 17:47:26.000000000 +0530
@@ -6581,7 +6581,7 @@ aic7xxx_slave_alloc(struct scsi_device *
struct aic7xxx_host *p = (struct aic7xxx_host *)SDptr->host->hostdata;
struct aic_dev_data *aic_dev;

- aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC | GFP_KERNEL);
+ aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_KERNEL);
if(!aic_dev)
return 1;
/*