Add file pattern to MAINTAINER entry
Signed-off-by: Joe Perches <[email protected]>
diff --git a/MAINTAINERS b/MAINTAINERS
index 36a7d25..edebf01 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1482,7 +1482,7 @@ L: [email protected]
S: Maintained
DIGI INTL. EPCA DRIVER
-P: Digi International, Inc
+P: Digi International Inc
M: [email protected]
L: [email protected]
W: http://www.digi.com
On Sun, 12 Aug 2007 23:26:16 -0700
[email protected] wrote:
> Add file pattern to MAINTAINER entry
>
> Signed-off-by: Joe Perches <[email protected]>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 36a7d25..edebf01 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1482,7 +1482,7 @@ L: [email protected]
> S: Maintained
>
> DIGI INTL. EPCA DRIVER
> -P: Digi International, Inc
> +P: Digi International Inc
The "," is correct and how they added themselves.
Please don't hide other types of change in a large changeset without
notice, thats not good
NAK
Alan Cox wrote:
> On Sun, 12 Aug 2007 23:26:16 -0700
> [email protected] wrote:
>> DIGI INTL. EPCA DRIVER
>> -P: Digi International, Inc
>> +P: Digi International Inc
>
> The "," is correct and how they added themselves.
>
> Please don't hide other types of change in a large changeset without
> notice, thats not good
>
> NAK
I'm not Joe, but I gather this change is in order to support generation
of RFC 278 headers by the proposed script.
However, rather than mangle entries in MAINTAINERS for the script, I
suggest that the script is enhanced instead. Simplest solution: If the
script finds punctuation and other problematic characters in the P:
field, simply omit that part from the e-mail address.
--
Stefan Richter
-=====-=-=== =--- -==-=
http://arcgraph.de/sr/
> I'm not Joe, but I gather this change is in order to support generation
> of RFC 278 headers by the proposed script.
The mail system supports comma characters if you must put names in and
this is well tested both for names and for usernames (because of TOPS,
old compu$erve etc)
Fix the script
Stefan Richter wrote:
> Alan Cox wrote:
>> On Sun, 12 Aug 2007 23:26:16 -0700
>> [email protected] wrote:
>>> DIGI INTL. EPCA DRIVER
>>> -P: Digi International, Inc
>>> +P: Digi International Inc
>> The "," is correct and how they added themselves.
>>
>> Please don't hide other types of change in a large changeset without
>> notice, thats not good
>>
>> NAK
>
> I'm not Joe, but I gather this change is in order to support generation
> of RFC 278 headers by the proposed script.
>
> However, rather than mangle entries in MAINTAINERS for the script, I
> suggest that the script is enhanced instead. Simplest solution: If the
> script finds punctuation and other problematic characters in the P:
> field, simply omit that part from the e-mail address.
or properly put it on "quotes":
Cc: "Digi International, Inc" <[email protected]>
is perfectly valid.
Auke
On Mon, 2007-08-13 at 09:15 -0700, Kok, Auke wrote:
> or properly put it on "quotes":
I'll improve the script and revert the name changes.
cheers, Joe
On Mon, 2007-08-13 at 09:35 -0700, Joe Perches wrote:
> On Mon, 2007-08-13 at 09:15 -0700, Kok, Auke wrote:
> > or properly put it on "quotes":
>
> I'll improve the script and revert the name changes.
# check for "must quote" chars in name
sub format_email {
my ($name, $email) = @_;
if ($name =~ tr@,\@<>@@) {
$formatted_email = "\"${name}\"\ \<${email}\>";
} else {
$formatted_email = "${name} \<${email}\>";
}
return $formatted_email;
}
Anyone know what chars require the name be quoted?
I've got: "," "@" "<" ">" ?
On Mon, 13 Aug 2007, Joe Perches wrote:
> On Mon, 2007-08-13 at 09:35 -0700, Joe Perches wrote:
> > On Mon, 2007-08-13 at 09:15 -0700, Kok, Auke wrote:
> > > or properly put it on "quotes":
> >
> > I'll improve the script and revert the name changes.
>
> # check for "must quote" chars in name
>
> sub format_email {
> my ($name, $email) = @_;
>
> if ($name =~ tr@,\@<>@@) {
> $formatted_email = "\"${name}\"\ \<${email}\>";
> } else {
> $formatted_email = "${name} \<${email}\>";
> }
> return $formatted_email;
> }
>
> Anyone know what chars require the name be quoted?
> I've got: "," "@" "<" ">" ?
Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape
double quotes (e.g. "Jonathan \"Jon\" Doe" <[email protected]>).
Cheers,
--
Cal Peake
On Tue, 2007-08-14 at 00:29 -0400, Cal Peake wrote:
> Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape
> double quotes (e.g. "Jonathan \"Jon\" Doe" <[email protected]>).
A-Z and [[:space:]] are OK too.
I skimmed the spec, but nothing jumped out at me.
On Mon, 13 Aug 2007, Joe Perches wrote:
> On Tue, 2007-08-14 at 00:29 -0400, Cal Peake wrote:
> > Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape
> > double quotes (e.g. "Jonathan \"Jon\" Doe" <[email protected]>).
>
> A-Z and [[:space:]] are OK too.
The 'i' at the end of the regex means case-insensitive ;) but yes, I
forgot whitespace. So something like:
if ($name =~ /[^a-z0-9[:space:]]/i) {
quote_name;
}
> I skimmed the spec, but nothing jumped out at me.
My recommendation was mostly based on what pine does. It seems to be a
pretty sane MUA...
--
Cal Peake
Cal Peake wrote:
> On Mon, 13 Aug 2007, Joe Perches wrote:
>
>> On Tue, 2007-08-14 at 00:29 -0400, Cal Peake wrote:
>>> Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape
>>> double quotes (e.g. "Jonathan \"Jon\" Doe" <[email protected]>).
>> A-Z and [[:space:]] are OK too.
>
> The 'i' at the end of the regex means case-insensitive ;) but yes, I
> forgot whitespace. So something like:
>
> if ($name =~ /[^a-z0-9[:space:]]/i) {
> quote_name;
> }
>
>> I skimmed the spec, but nothing jumped out at me.
>
> My recommendation was mostly based on what pine does. It seems to be a
> pretty sane MUA...
Better: Dig out the respective RFCs or/and use a library (perl module
or whatever) for the recoding into mail header formats.
--
Stefan Richter
-=====-=-=== =--- -===-
http://arcgraph.de/sr/