2007-09-28 02:05:42

by Dave Airlie

[permalink] [raw]
Subject: [PATCH] i915: make vbl interrupts work properly on i965g/gm


Hi Linus,

The attached patch is to fix a bug reported on 965gm chipsets (lots of new
laptops), I think distros will all have to patch this in to fix it, so can
we get it into the 2.6.23 final?

(Otherwise I'll wait until stable..)

Dave.


Attachments:
0001-i915-make-vbl-interrupts-work-properly-on-i965g-gm.patch (2.42 kB)

2007-09-28 02:16:17

by Jesse Barnes

[permalink] [raw]
Subject: Re: [PATCH] i915: make vbl interrupts work properly on i965g/gm

On Thursday, September 27, 2007 7:05:31 pm Dave Airlie wrote:
> Hi Linus,
>
> The attached patch is to fix a bug reported on 965gm chipsets (lots of new
> laptops), I think distros will all have to patch this in to fix it, so can
> we get it into the 2.6.23 final?
>
> (Otherwise I'll wait until stable..)

Without this patch, my 965GM drops vblank interrupts, so I'd really like to
see it upstream ASAP too.

Acked-by: Jesse Barnes <[email protected]>

2007-09-28 20:02:18

by Roland Dreier

[permalink] [raw]
Subject: Re: [PATCH] i915: make vbl interrupts work properly on i965g/gm

Sorry to hijack this thread, but I have a question about i915
interrupts (945GM specifically) that I haven't gotten an answer to
yet, and this thread reminded me of it so I thought I'd ask again:
I hacked the kernel drm stuff on my laptop with 945GM graphics to do
pci_enable_msi() on the graphics device, and I don't see any
interrupts occur.

So can someone with access to details of the 945GM tell me if MSI
interrupts should work, and if so if there's some internal registers
that need to be poked to enable it (beyond what pci_enable_msi()
does).

It's not super-urgent-- I just like using shiny things like MSI, and I
already have ahci, iwl3945 and e1000 working with MSI on my laptop, so
the graphics are the only thing left with an MSI capability that's not
working.

Thanks!
Roland

2007-09-28 20:10:04

by Jesse Barnes

[permalink] [raw]
Subject: Re: [PATCH] i915: make vbl interrupts work properly on i965g/gm

On Friday, September 28, 2007 1:02 pm Roland Dreier wrote:
> Sorry to hijack this thread, but I have a question about i915
> interrupts (945GM specifically) that I haven't gotten an answer to
> yet, and this thread reminded me of it so I thought I'd ask again:
> I hacked the kernel drm stuff on my laptop with 945GM graphics to do
> pci_enable_msi() on the graphics device, and I don't see any
> interrupts occur.
>
> So can someone with access to details of the 945GM tell me if MSI
> interrupts should work, and if so if there's some internal registers
> that need to be poked to enable it (beyond what pci_enable_msi()
> does).
>
> It's not super-urgent-- I just like using shiny things like MSI, and
> I already have ahci, iwl3945 and e1000 working with MSI on my laptop,
> so the graphics are the only thing left with an MSI capability that's
> not working.

I don't have a 945 to test with, but Dave might...

Jesse

2007-09-28 22:24:14

by Roland Dreier

[permalink] [raw]
Subject: Re: [PATCH] i915: make vbl interrupts work properly on i965g/gm

> I don't have a 945 to test with, but Dave might...

Actually I'm not looking for testing (I can test fine on my own laptop :)
I was just hoping someone with docs could tell me "MSI is documented to be
broken on 945GM" or "Oh yeah, 945GM requires you to set SECRET_MSI_ENABLE_BIT
in register FOO before it generates MSIs."

As I said, it's not a big deal but I'd sort of like to know whether my
MSI enable hack at least has a chance at working before I try too hard
to get it working.

Thanks,
Roland

2007-09-28 23:16:18

by Jesse Barnes

[permalink] [raw]
Subject: Re: [PATCH] i915: make vbl interrupts work properly on i965g/gm

On Friday, September 28, 2007 3:23 pm Roland Dreier wrote:
> > I don't have a 945 to test with, but Dave might...
>
> Actually I'm not looking for testing (I can test fine on my own
> laptop :) I was just hoping someone with docs could tell me "MSI is
> documented to be broken on 945GM" or "Oh yeah, 945GM requires you to
> set SECRET_MSI_ENABLE_BIT in register FOO before it generates MSIs."
>
> As I said, it's not a big deal but I'd sort of like to know whether
> my MSI enable hack at least has a chance at working before I try too
> hard to get it working.

I don't see anything in the docs (either public or private) that would
indicate that MSI is broken on those chips, so I'd expect it to work...

Jesse