2007-10-10 22:20:09

by Rob Landley

[permalink] [raw]
Subject: m68k Kconfig undefined symbol in 2.6.23.

The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.

I did this to fix it, without really understanding the larger problem. (Did
APM go away?) Just FYI...

Rob

diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig
--- a/drivers/macintosh/Kconfig Tue Oct 09 21:00:40 2007 +0000
+++ b/drivers/macintosh/Kconfig Wed Oct 10 17:17:07 2007 -0500
@@ -116,11 +116,6 @@ config PMAC_SMU
on the "SMU" system control chip which replaces the old PMU.
If you don't know, say Y.

-config PMAC_APM_EMU
- tristate "APM emulation"
- select APM_EMULATION
- depends on ADB_PMU && PM && PPC32
-
config PMAC_MEDIABAY
bool "Support PowerBook hotswap media bay"
depends on PPC_PMAC && PPC32

--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.


2007-10-11 07:16:17

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: m68k Kconfig undefined symbol in 2.6.23.

On Wed, 10 Oct 2007, Rob Landley wrote:
> The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.
>
> I did this to fix it, without really understanding the larger problem. (Did
> APM go away?) Just FYI...
>
> Rob
>
> diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig
> --- a/drivers/macintosh/Kconfig Tue Oct 09 21:00:40 2007 +0000
> +++ b/drivers/macintosh/Kconfig Wed Oct 10 17:17:07 2007 -0500
> @@ -116,11 +116,6 @@ config PMAC_SMU
> on the "SMU" system control chip which replaces the old PMU.
> If you don't know, say Y.
>
> -config PMAC_APM_EMU
> - tristate "APM emulation"
> - select APM_EMULATION
> - depends on ADB_PMU && PM && PPC32
^^^^^
I.e. PPC, not m68k.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2007-10-11 12:10:39

by Robert P. J. Day

[permalink] [raw]
Subject: Re: m68k Kconfig undefined symbol in 2.6.23.

On Wed, 10 Oct 2007, Rob Landley wrote:

> The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.
>
> I did this to fix it, without really understanding the larger problem. (Did
> APM go away?) Just FYI...
>
> Rob
>
> diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig
> --- a/drivers/macintosh/Kconfig Tue Oct 09 21:00:40 2007 +0000
> +++ b/drivers/macintosh/Kconfig Wed Oct 10 17:17:07 2007 -0500
> @@ -116,11 +116,6 @@ config PMAC_SMU
> on the "SMU" system control chip which replaces the old PMU.
> If you don't know, say Y.
>
> -config PMAC_APM_EMU
> - tristate "APM emulation"
> - select APM_EMULATION
> - depends on ADB_PMU && PM && PPC32
> -
> config PMAC_MEDIABAY
> bool "Support PowerBook hotswap media bay"
> depends on PPC_PMAC && PPC32

the obvious problem with the above is that APM_EMULATION is defined in
kernel/power/Kconfig arch-independently thusly:

config APM_EMULATION
tristate "Advanced Power Management Emulation"
depends on PM && SYS_SUPPORTS_APM_EMULATION
help
... blah blah ...

but the Kconfig variable SYS_SUPPORTS_APM_EMULATION is defined for
only a small subset of architectures:

$ grep "config SYS_SUPPORTS_APM_EMULATION" $(find . -name Kconfig*)
./arch/mips/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/sh/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/arm/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/powerpc/Kconfig:config SYS_SUPPORTS_APM_EMULATION

so there's a good chance that doing a kernel config with any other
arch than those listed above that supports PM is going to generate the
same warning.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================