2007-10-24 16:31:36

by Adrian Bunk

Subject: [2.6 patch] make tcp_match_skb_to_sack() static

tcp_match_skb_to_sack() can become static.

Signed-off-by: Adrian Bunk <[email protected]>

---
b734b439219a6251b7deb65dad2307f9c891f680
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 9288220..603400d 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1204,8 +1204,8 @@ static int tcp_check_dsack(struct tcp_sock *tp, struct sk_buff *ack_skb,
* which may fail and creates some hassle (caller must handle error case
* returns).
*/
-int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
- u32 start_seq, u32 end_seq)
+static int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
+ u32 start_seq, u32 end_seq)
{
int in_sack, err;
unsigned int pkt_len;

2007-10-24 21:40:47

by Ilpo Järvinen

Subject: Re: [2.6 patch] make tcp_match_skb_to_sack() static

On Wed, 24 Oct 2007, Adrian Bunk wrote:

> tcp_match_skb_to_sack() can become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
[...snip...]

Thanks, I should have noticed that right from the beginning...

Added DaveM to recipients.

--
i.

2007-10-26 10:57:56

by David Miller

Subject: Re: [2.6 patch] make tcp_match_skb_to_sack() static

From: "Ilpo_J?rvinen" <[email protected]>
Date: Thu, 25 Oct 2007 00:39:23 +0300 (EEST)

> On Wed, 24 Oct 2007, Adrian Bunk wrote:
>
> > tcp_match_skb_to_sack() can become static.
> >
> > Signed-off-by: Adrian Bunk <[email protected]>
> >
> [...snip...]
>
> Thanks, I should have noticed that right from the beginning...

Yep, applied, thanks!