2007-10-31 03:52:03

by Stephen Rothwell

[permalink] [raw]

Subject: [PATCH] hiddev: compat_ptr() returns a void *

---

so cast it to unsigned long before passing it to hiddev_ioctl.

This gets rid of:

drivers/hid/usbhid/hiddev.c: In function 'hiddev_compat_ioctl':
drivers/hid/usbhid/hiddev.c:746: warning: passing argument 4 of 'hiddev_ioctl' makes integer from pointer without a cast

Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/hid/usbhid/hiddev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

--
Cheers,
Stephen Rothwell [email protected]

diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 9837adc..5fc4019 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -743,7 +743,7 @@ inval:
static long hiddev_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
{
struct inode *inode = file->f_path.dentry->d_inode;
- return hiddev_ioctl(inode, file, cmd, compat_ptr(arg));
+ return hiddev_ioctl(inode, file, cmd, (unsigned long)compat_ptr(arg));
}
#endif

--
1.5.3.4

2007-10-31 11:28:04

by Jiri Kosina

[permalink] [raw]

Subject: Re: [PATCH] hiddev: compat_ptr() returns a void *

---

On Wed, 31 Oct 2007, Stephen Rothwell wrote:

> so cast it to unsigned long before passing it to hiddev_ioctl.
> This gets rid of:
> drivers/hid/usbhid/hiddev.c: In function 'hiddev_compat_ioctl':
> drivers/hid/usbhid/hiddev.c:746: warning: passing argument 4 of 'hiddev_ioctl' makes integer from pointer without a cast
> Signed-off-by: Stephen Rothwell <[email protected]>

Hi Stephen,

I already have this fixed in my tree, sorry.

Thanks a lot,

--
Jiri Kosina

2007-11-01 00:51:17

by Stephen Rothwell

[permalink] [raw]

Subject: Re: [PATCH] hiddev: compat_ptr() returns a void *

---

On Wed, 31 Oct 2007 12:27:24 +0100 (CET) Jiri Kosina <[email protected]> wrote:
>
> I already have this fixed in my tree, sorry.

As long as it gets fixed, I don't mind.

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

---

Attachments:

(No filename) (271.00 B)
(No filename) (189.00 B)
Download all attachments