with the attached config i get this build failure:
drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
: undefined reference to `dib3000mc_get_tuner_i2c_master'
drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
: undefined reference to `dib3000mc_set_config'
on 2.6.24-rc-latest.
Ingo
On Tue, 4 Dec 2007, Ingo Molnar wrote:
> with the attached config i get this build failure:
> drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
> : undefined reference to `dib3000mc_get_tuner_i2c_master'
> drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
> : undefined reference to `dib3000mc_set_config'
> on 2.6.24-rc-latest.
Hmm, seems like -common part contains also code that is not completely
common to all the modules.
How about this?
From: Jiri Kosina <[email protected]>
DVB: Compile 3000MC-specific DIB code only for CONFIG_DVB_DIB3000MC
Signed-off-by: Jiri Kosina <[email protected]>
diff --git a/drivers/media/dvb/dvb-usb/dibusb-common.c b/drivers/media/dvb/dvb-usb/dibusb-common.c
index 9a184da..b95b1eb 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-common.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-common.c
@@ -223,6 +223,7 @@ static struct dibx000_agc_config dib3000p_panasonic_agc_config = {
.agc2_slope2 = 0x1e,
};
+#ifdef CONFIG_DVB_DIB3000MC
static struct dib3000mc_config mod3000p_dib3000p_config = {
&dib3000p_panasonic_agc_config,
@@ -305,6 +306,7 @@ int dibusb_dib3000mc_tuner_attach(struct dvb_usb_adapter *adap)
return 0;
}
EXPORT_SYMBOL(dibusb_dib3000mc_tuner_attach);
+#endif
/*
* common remote control stuff
* Jiri Kosina <[email protected]> wrote:
> On Tue, 4 Dec 2007, Ingo Molnar wrote:
>
> > with the attached config i get this build failure:
> > drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
> > : undefined reference to `dib3000mc_get_tuner_i2c_master'
> > drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
> > : undefined reference to `dib3000mc_set_config'
> > on 2.6.24-rc-latest.
>
> Hmm, seems like -common part contains also code that is not completely
> common to all the modules.
>
> How about this?
that does the trick and 2.6.24-rc4 now builds & boots fine with that
config. Thanks,
Tested-by: Ingo Molnar <[email protected]>
Ingo
On Tue, 4 Dec 2007, Ingo Molnar wrote:
> > Hmm, seems like -common part contains also code that is not completely
> > common to all the modules.
> > How about this?
> that does the trick and 2.6.24-rc4 now builds & boots fine with that
> config. Thanks,
> Tested-by: Ingo Molnar <[email protected]>
Mauro, Patrick, are you going to take it through your trees, or should I
push it through akpm?
--
Jiri Kosina
Em Qua, 2007-12-05 às 11:33 +0100, Jiri Kosina escreveu:
> On Tue, 4 Dec 2007, Ingo Molnar wrote:
>
> > > Hmm, seems like -common part contains also code that is not completely
> > > common to all the modules.
> > > How about this?
> > that does the trick and 2.6.24-rc4 now builds & boots fine with that
> > config. Thanks,
> > Tested-by: Ingo Molnar <[email protected]>
>
> Mauro, Patrick, are you going to take it through your trees, or should I
> push it through akpm?
Jiri/Ingo,
I'll take care of this patch.
--
Cheers,
Mauro