2008-02-29 18:26:42

by Thomas Voegtle

Subject: permissions on /proc/tty/driver/

Hi,

we noticed that only root can enter /proc/tty/driver/, which appears to be
wrong, because the files therein are actually world readable...



Signed-off-by: Tilman Baumann <[email protected]>
Signed-off-by: Thomas Voegtle <[email protected]>
---
fs/proc/proc_tty.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/proc/proc_tty.c b/fs/proc/proc_tty.c
index 49816e0..eb73d96 100644
--- a/fs/proc/proc_tty.c
+++ b/fs/proc/proc_tty.c
@@ -224,7 +224,9 @@ void __init proc_tty_init(void)
* password lengths and inter-keystroke timings during password
* entry.
*/
- proc_tty_driver = proc_mkdir_mode("tty/driver", S_IRUSR | S_IXUSR, NULL);
+ proc_tty_driver = proc_mkdir_mode("tty/driver",
+ S_IRUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH,
+ NULL);

create_proc_read_entry("tty/ldiscs", 0, NULL, tty_ldiscs_read_proc, NULL);
entry = create_proc_entry("tty/drivers", 0, NULL);
--
1.5.3

Thomas

--
Thomas V?gtle email: [email protected]
----- http://www.voegtle-clan.de/thomas ------

2008-03-03 16:42:52

by Thomas Voegtle

Subject: Re: permissions on /proc/tty/driver/

On Fri, 29 Feb 2008, Thomas Voegtle wrote:

> we noticed that only root can enter /proc/tty/driver/, which appears to be
> wrong, because the files therein are actually world readable...

I found out why this was done:

http://www.kernel.org/pub/linux/kernel/v2.4/ChangeLog-2.4.29

Chris Wright:
o /proc/tty/driver/serial reveals the exact number of characters used
in serial links (CAN-2003-0461)


So, please ignore this patch I sent.

Thomas

--
Thomas V?gtle email: [email protected]
----- http://www.voegtle-clan.de/thomas ------