2008-06-05 08:37:26

by Guennadi Liakhovetski

Subject: [PATCH] spi: fix list scan success verification in PXA ssp driver

The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
example, it didn't recognise failure for me when I requested port 0.

Signed-off-by: Guennadi Liakhovetski <[email protected]>

---

arch/arm/mach-pxa/ssp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/arch/arm/mach-pxa/ssp.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:26.000000000 +0200
+++ linux-2.6/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:50.000000000 +0200
@@ -330,7 +330,7 @@

mutex_unlock(&ssp_lock);

- if (ssp->port_id != port)
+ if (&ssp->node == &ssp_list)
return NULL;

return ssp;

2008-06-05 08:46:00

by Eric Miao

Subject: RE: [PATCH] spi: fix list scan success verification in PXA ssp driver

Acked-by: Eric Miao <[email protected]>

And this should really go through the ARM tree, please submit the patch
to RMK's patch system. Thanks.

Cheers
- eric

> -----Original Message-----
> From: Guennadi Liakhovetski [mailto:[email protected]]
> Sent: Thursday, June 05, 2008 4:37 PM
> To: [email protected]
> Cc: [email protected]; Eric Miao;
> [email protected]
> Subject: [PATCH] spi: fix list scan success verification in PXA ssp driver
>
> The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
> example, it didn't recognise failure for me when I requested port 0.
>
> Signed-off-by: Guennadi Liakhovetski <[email protected]>
>
> ---
>
> arch/arm/mach-pxa/ssp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/arch/arm/mach-pxa/ssp.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:26.000000000
> +0200
> +++ linux-2.6/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:50.000000000 +0200
> @@ -330,7 +330,7 @@
>
> mutex_unlock(&ssp_lock);
>
> - if (ssp->port_id != port)
> + if (&ssp->node == &ssp_list)
> return NULL;
>
> return ssp;

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?

2008-06-05 08:54:54

by Eric Miao

Subject: Re: [PATCH] spi: fix list scan success verification in PXA ssp driver

Acked-by: Eric Miao <[email protected]>

And this should really go through the ARM tree, please submit the
patch to RMK's patch system. Thanks.

(I have to send this again through my gmail account, please ignore the
other copy if any,
sorry for this)

On Thu, Jun 5, 2008 at 4:37 PM, Guennadi Liakhovetski
<[email protected]> wrote:
> The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
> example, it didn't recognise failure for me when I requested port 0.
>
> Signed-off-by: Guennadi Liakhovetski <[email protected]>
>
> ---
>
> arch/arm/mach-pxa/ssp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/arch/arm/mach-pxa/ssp.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:26.000000000 +0200
> +++ linux-2.6/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:50.000000000 +0200
> @@ -330,7 +330,7 @@
>
> mutex_unlock(&ssp_lock);
>
> - if (ssp->port_id != port)
> + if (&ssp->node == &ssp_list)
> return NULL;
>
> return ssp;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>



--
Cheers
- eric