Hi all,
Setting up my new AMD64 I noticed a curious one liner in syslogs:
^Iwith "disable_clustering=1" and report to maintainers
The attached patch fixes this up so he goes back to his wife
in /var/log/messages (or wherever KERN_INFO logs on the system):
DC390: clustering now enabled by default. If you get problems load
with "disable_clustering=1" and report to maintainers
The patch was created on stable 2.6.26.2 git tree.
Nick
Signed off by: "Nick Warne" <[email protected]>
--
Free Software Foundation Associate Member 5508
On Fri, 15 Aug 2008, Nick Warne wrote:
> Setting up my new AMD64 I noticed a curious one liner in syslogs:
Wow, are you sure you need the tmscsim driver on your new amd64 system?:-)
> ^Iwith "disable_clustering=1" and report to maintainers
The message priority is indeed missing in the second line, but it has
nothing to do with the "^I" in your log. I do not know why your syslogd /
klogd converts a TAB to "^I". But if it is a problem, I think, the correct
fix would be something like
- printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n"
- "\twith \"disable_clustering=1\" and report to maintainers\n");
+ printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
+ printk(KERN_INFO " with \"disable_clustering=1\" and report to maintainers\n");
Or maybe just remove that printk altogether - it has been there for almost
2 years now, and I haven't heard a single complaint, but on the other
hand, maybe you are the first, who at least loaded this driver since 2
years:-)
Ok, taking into account that this driver is hardly used, I would keep this
warning in case someone does get a problem.
So, please, redo as above, create with "-p1" format, fix your Sob line
> Signed off by: "Nick Warne" <[email protected]>
which has to be
Signed-off-by: Nick Warne <[email protected]>
and send the patch inline,
Thanks
Guennadi
---
Guennadi Liakhovetski
On Fri, 15 Aug 2008 22:17:57 +0200 (CEST)
Guennadi Liakhovetski <[email protected]> wrote:
> On Fri, 15 Aug 2008, Nick Warne wrote:
> Wow, are you sure you need the tmscsim driver on your new amd64
> system?:-)
I don't know :-) A new distro (Slackware 12.1) has almost everything
set as modules, so I am currently building new kernel removing them as I
go - just the first couple of log scans revealed this...
> I do not know why your
> syslogd / klogd converts a TAB to "^I".
Mystery to me too...
> So, please, redo as above, create with "-p1" format, fix your Sob line
Thanks.
Nick
New patch attached.
Signed off by: Nick Warne [email protected]
--- linux-2.6.26.y/drivers/scsi/tmscsim.cORIG 2008-08-15 10:30:47.000000000 +0100
+++ linux-2.6.26.y/drivers/scsi/tmscsim.c 2008-08-16 08:45:43.000000000 +0100
@@ -2573,8 +2573,8 @@
static int __init dc390_module_init(void)
{
if (!disable_clustering)
- printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n"
- "\twith \"disable_clustering=1\" and report to maintainers\n");
+ printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
+ printk(KERN_INFO " with \"disable_clustering=1\" and report to maintainers\n");
if (tmscsim[0] == -1 || tmscsim[0] > 15) {
tmscsim[0] = 7;
--
Free Software Foundation Associate Member 5508