2008-10-09 18:55:20

by Hans Schou

Subject: [PATCH] More informative about unknown CPU

Hi

Write the name of the unknown vendor_id to output instead of just "file
not found".

Tag changed to 'vendor_id' as used in /proc/cpuinfo

Signed-off-by: Hans Schou <[email protected]>


--- linux.trees.git/arch/x86/kernel/cpu/common.c.orig 2008-10-09 17:33:29.000000000 +0200
+++ linux.trees.git/arch/x86/kernel/cpu/common.c 2008-10-09 17:33:59.000000000 +0200
@@ -413,7 +413,7 @@ static void __cpuinit get_cpu_vendor(str

if (!printed) {
printed++;
- printk(KERN_ERR "CPU: Vendor unknown, using generic init.\n");
+ printk(KERN_ERR "CPU: vendor_id '%s' unknown, using generic init.\n", v);
printk(KERN_ERR "CPU: Your system may be unstable.\n");
}

2008-10-10 15:05:34

by Ingo Molnar

Subject: Re: [PATCH] More informative about unknown CPU

* Hans Schou <[email protected]> wrote:

> Hi
>
> Write the name of the unknown vendor_id to output instead of just
> "file not found".
>
> Tag changed to 'vendor_id' as used in /proc/cpuinfo
>
> Signed-off-by: Hans Schou <[email protected]>

applied to tip/x86/unify-cpu-detect, thanks Hans!

> --- linux.trees.git/arch/x86/kernel/cpu/common.c.orig 2008-10-09 17:33:29.000000000 +0200
> +++ linux.trees.git/arch/x86/kernel/cpu/common.c 2008-10-09 17:33:59.000000000 +0200
> @@ -413,7 +413,7 @@ static void __cpuinit get_cpu_vendor(str
>
> if (!printed) {
> printed++;
> - printk(KERN_ERR "CPU: Vendor unknown, using generic init.\n");
> + printk(KERN_ERR "CPU: vendor_id '%s' unknown, using generic init.\n", v);
> printk(KERN_ERR "CPU: Your system may be unstable.\n");

btw., this was whitespace damaged (i fixed that up by hand). See
Documentation/email-clients.txt about how to set up the email client.
(or, when you send x86 patches, you can attach the patch as a MIME
attachment)

Ingo

2008-10-10 16:20:33

by Yinghai Lu

Subject: Re: [PATCH] More informative about unknown CPU

On Fri, Oct 10, 2008 at 8:04 AM, Ingo Molnar <[email protected]> wrote:
>
> * Hans Schou <[email protected]> wrote:
>
>> Hi
>>
>> Write the name of the unknown vendor_id to output instead of just
>> "file not found".
>>
>> Tag changed to 'vendor_id' as used in /proc/cpuinfo
>>
>> Signed-off-by: Hans Schou <[email protected]>
>
> applied to tip/x86/unify-cpu-detect, thanks Hans!
>
>> --- linux.trees.git/arch/x86/kernel/cpu/common.c.orig 2008-10-09 17:33:29.000000000 +0200
>> +++ linux.trees.git/arch/x86/kernel/cpu/common.c 2008-10-09 17:33:59.000000000 +0200
>> @@ -413,7 +413,7 @@ static void __cpuinit get_cpu_vendor(str
>>
>> if (!printed) {
>> printed++;
>> - printk(KERN_ERR "CPU: Vendor unknown, using generic init.\n");
>> + printk(KERN_ERR "CPU: vendor_id '%s' unknown, using generic init.\n", v);
>> printk(KERN_ERR "CPU: Your system may be unstable.\n");
>
> btw., this was whitespace damaged (i fixed that up by hand). See
> Documentation/email-clients.txt about how to set up the email client.
> (or, when you send x86 patches, you can attach the patch as a MIME
> attachment)
>

What is unknown cpus?

>From Sis or Nvidia?

YH

2008-10-10 16:24:41

by H. Peter Anvin

Subject: Re: [PATCH] More informative about unknown CPU

Yinghai Lu wrote:
>
> What is unknown cpus?
>
> From Sis or Nvidia?
>

Virtual CPUs, vendors who suddenly pop up, ...

-hpa