2008-10-30 10:58:54

by Ilpo Järvinen

Subject: [PATCH] scsi/tmscsim: fix indentation and braces disagreement - add braces

Lucky winner is 557cc476c04 ([SCSI] tmscsim: Fixup
KERN_INFO in printk).

Signed-off-by: Ilpo J?rvinen <[email protected]>
Cc: Nick Warne <[email protected]>
---
drivers/scsi/tmscsim.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index 69ac6e5..9a42734 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2572,9 +2572,10 @@ static struct pci_driver dc390_driver = {

static int __init dc390_module_init(void)
{
- if (!disable_clustering)
+ if (!disable_clustering) {
printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
printk(KERN_INFO " with \"disable_clustering=1\" and report to maintainers\n");
+ }

if (tmscsim[0] == -1 || tmscsim[0] > 15) {
tmscsim[0] = 7;
--
1.5.2.2

2008-10-30 18:17:24

by Guennadi Liakhovetski

Subject: Re: [PATCH] scsi/tmscsim: fix indentation and braces disagreement - add braces

On Thu, 30 Oct 2008, Ilpo J?rvinen wrote:

>
> Lucky winner is 557cc476c04 ([SCSI] tmscsim: Fixup
> KERN_INFO in printk).
>
> Signed-off-by: Ilpo J?rvinen <[email protected]>
> Cc: Nick Warne <[email protected]>

Oops...:-(

Acked-by: Guennadi Liakhovetski <[email protected]>

> ---
> drivers/scsi/tmscsim.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
> index 69ac6e5..9a42734 100644
> --- a/drivers/scsi/tmscsim.c
> +++ b/drivers/scsi/tmscsim.c
> @@ -2572,9 +2572,10 @@ static struct pci_driver dc390_driver = {
>
> static int __init dc390_module_init(void)
> {
> - if (!disable_clustering)
> + if (!disable_clustering) {
> printk(KERN_INFO "DC390: clustering now enabled by default. If you get problems load\n");
> printk(KERN_INFO " with \"disable_clustering=1\" and report to maintainers\n");
> + }
>
> if (tmscsim[0] == -1 || tmscsim[0] > 15) {
> tmscsim[0] = 7;
> --
> 1.5.2.2
>

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer