2008-11-24 09:57:39

by Guennadi Liakhovetski

[permalink] [raw]
Subject: leds/leds-pca955x.c: small and, probably, hatmless race window

Hi,

leds/leds-pca955x.c does on two occasions:

kfree(pca955x);
i2c_set_clientdata(client, NULL);

which means, between these two calls dev->driver_data points to a freed
location. One of these two occasions is in probe on the error path,
another in release, thus, both are, probably, harmless, still would be
better to fix?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected]