On Fri, May 15, 2009 at 03:28:18PM +0200, Floris Kraak wrote:
> On 5/15/09, Pekka Enberg <[email protected]> wrote:
> >
> > On Wed, Feb 4, 2009 at 5:28 PM, Floris Kraak <[email protected]> wrote:
> > > Some distributions have enabled the gcc flag -Wformat-security by default.*
> > > This results in a number of warnings about format arguments to
> > > functions, sometimes in cases where fixing the warning is not likely
> > > to actually fix a bug.
> > > Instead of hand patching a dozens of places (possibly more) that
> > > produce warnings that get ignored anyway we just turn off the flag in
> > > the Makefile.
> > >
> >
> > Is there a reason this patch was not merged? Yes, it's clearly a
> > distro problem but apparently there's no easy way to turn it off.
> >
I have lost the original patch to disable this check.
Could you please resend.
Thanks,
Sam
From: Floris Kraak <[email protected]>
Some distributions have enabled the gcc flag -Wformat-security by default.
This results in a number of warnings about format arguments to functions,
sometimes in cases where fixing the warning is not likely to actually fix a
bug. Instead of hand patching a dozens of places (possibly more) that produce
warnings that get ignored anyway we just turn off the flag in the Makefile.
Signed-off-by: Floris Kraak <[email protected]>
Signed-off-by: Pekka Enberg <[email protected]>
---
Makefile | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 03373bb..5ef1f72 100644
--- a/Makefile
+++ b/Makefile
@@ -351,7 +351,8 @@ KBUILD_CPPFLAGS := -D__KERNEL__
KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
-fno-strict-aliasing -fno-common \
- -Werror-implicit-function-declaration
+ -Werror-implicit-function-declaration \
+ -Wno-format-security
KBUILD_AFLAGS := -D__ASSEMBLY__
# Read KERNELRELEASE from include/config/kernel.release (if it exists)
--
1.6.0.4
On Mon, Jun 15, 2009 at 7:54 AM, Pekka J Enberg<[email protected]> wrote:
> From: Floris Kraak <[email protected]>
>
[snip]
Thanks Pekka :-)
Regards,
Floris
---
'Or lawyers may say, “But if I decline, someone else will do it. So
what is gained?” My reply: “Let someone else do it. But not you. Honor
is personal. Worry about yourself. You don’t get a pass from moral
responsibility because you acted for a client.”
That’s the first lesson I would offer, aimed at lawyers. A second
lesson, aimed at all, is this: Keep ready your capacity for outrage.
This is very important. Next to the vote, outrage is the one response
each of us can contribute. Outrage is how honor must confront
dishonor. If we lose the capacity for outrage, we are in serious
trouble. '
--- Stephen Gillers
On Mon, Jun 15, 2009 at 08:54:02AM +0300, Pekka J Enberg wrote:
> From: Floris Kraak <[email protected]>
>
> Some distributions have enabled the gcc flag -Wformat-security by default.
> This results in a number of warnings about format arguments to functions,
> sometimes in cases where fixing the warning is not likely to actually fix a
> bug. Instead of hand patching a dozens of places (possibly more) that produce
> warnings that get ignored anyway we just turn off the flag in the Makefile.
>
> Signed-off-by: Floris Kraak <[email protected]>
> Signed-off-by: Pekka Enberg <[email protected]>
Applied.
Sam