This patch adds driver for HTC Dream camera. I guess driver is
slightly higher quality than usual for staging/ , but it is fairly big
and I don't feel like doing all the cleanups myself. Also some parts
can probably be removed, as they did not end up in shipping hardware..
The driver is actually so big that I'll attach it gzipped, otherwise
it would not pass maillist limits.
Signed-off-by: Pavel Machek <[email protected]>
Cc: Brian Swetland <[email protected]>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Mon, 29 Jun 2009, Pavel Machek wrote:
>
> This patch adds driver for HTC Dream camera. I guess driver is
> slightly higher quality than usual for staging/ , but it is fairly big
> and I don't feel like doing all the cleanups myself. Also some parts
> can probably be removed, as they did not end up in shipping hardware..
>
> The driver is actually so big that I'll attach it gzipped, otherwise
> it would not pass maillist limits.
when this patch will be leaving the "staging" state, it will have to be
converted to use v4l2-subdev API and submitted to linux-media.
> Signed-off-by: Pavel Machek <[email protected]>
> Cc: Brian Swetland <[email protected]>
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
On Mon, Jun 29, 2009 at 08:28:33PM +0200, Guennadi Liakhovetski wrote:
> On Mon, 29 Jun 2009, Pavel Machek wrote:
>
> >
> > This patch adds driver for HTC Dream camera. I guess driver is
> > slightly higher quality than usual for staging/ , but it is fairly big
> > and I don't feel like doing all the cleanups myself. Also some parts
> > can probably be removed, as they did not end up in shipping hardware..
> >
> > The driver is actually so big that I'll attach it gzipped, otherwise
> > it would not pass maillist limits.
>
> when this patch will be leaving the "staging" state, it will have to be
> converted to use v4l2-subdev API and submitted to linux-media.
Sounds reasonable. All staging patches are submitted to the respective
subsystems for inclusion in order to move out of them. So that's
nothing new.
thanks,
greg k-h
On Mon, Jun 29, 2009 at 01:43:40PM +0200, Pavel Machek wrote:
>
> This patch adds driver for HTC Dream camera. I guess driver is
> slightly higher quality than usual for staging/ , but it is fairly big
> and I don't feel like doing all the cleanups myself. Also some parts
> can probably be removed, as they did not end up in shipping hardware..
>
> The driver is actually so big that I'll attach it gzipped, otherwise
> it would not pass maillist limits.
>
> Signed-off-by: Pavel Machek <[email protected]>
> Cc: Brian Swetland <[email protected]>
Can you resubmit it with the original author descriptions? It's not
fair to them to have it shown up as coming from you.
thanks,
greg k-h
On Thu 2009-07-02 13:08:24, Greg KH wrote:
> On Mon, Jun 29, 2009 at 01:43:40PM +0200, Pavel Machek wrote:
> >
> > This patch adds driver for HTC Dream camera. I guess driver is
> > slightly higher quality than usual for staging/ , but it is fairly big
> > and I don't feel like doing all the cleanups myself. Also some parts
> > can probably be removed, as they did not end up in shipping hardware..
> >
> > The driver is actually so big that I'll attach it gzipped, otherwise
> > it would not pass maillist limits.
> >
> > Signed-off-by: Pavel Machek <[email protected]>
> > Cc: Brian Swetland <[email protected]>
>
> Can you resubmit it with the original author descriptions? It's not
> fair to them to have it shown up as coming from you.
Yes, done... and thanks.
Brian... I'd like to submit qdsp5 and smd code, too. Who should be
listed as their authors?
Oh and... thanks for the serial debugging cable. After short fight
(using ttyMSM2, not ttyS0 took me a while to figure), it seems to work.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Wed, Jul 8, 2009 at 1:44 AM, Pavel Machek<[email protected]> wrote:
> On Thu 2009-07-02 13:08:24, Greg KH wrote:
>> On Mon, Jun 29, 2009 at 01:43:40PM +0200, Pavel Machek wrote:
>> >
>> > This patch adds driver for HTC Dream camera. I guess driver is
>> > slightly higher quality than usual for staging/ , but it is fairly big
>> > and I don't feel like doing all the cleanups myself. Also some parts
>> > can probably be removed, as they did not end up in shipping hardware..
>> >
>> > The driver is actually so big that I'll attach it gzipped, otherwise
>> > it would not pass maillist limits.
>> >
>> > Signed-off-by: Pavel Machek <[email protected]>
>> > Cc: Brian Swetland <[email protected]>
>>
>> Can you resubmit it with the original author descriptions? It's not
>> fair to them to have it shown up as coming from you.
>
> Yes, done... and thanks.
>
> Brian... I'd like to submit qdsp5 and smd code, too. Who should be
> listed as their authors?
smd is pretty much my fault at this point, though Arve hacks on the
PM-related bits.
The latest incarnation of the rpcrouter is me, with a lot of the
original work by Iliyan, based heavily on the work Qualcomm did (thus
their copyright on it as well as Google's).
qdsp5 is Iliyan.
Might be worth breaking these into at least three pieces (smd,
rpcrouter, qdsp5)?
Are you highly opposed to having smd and rpcrouter under
arch/arm/mach-msm? They're (for better or worse) pretty integral to
the core operation of the platform (suspend/resume and a lot of other
core SoC functions require coordination with the modem core).
The qdsp5 stuff could exist elsewhere easily (though I'm not sure
where the logical place is), and stuff on top of it like the v4l2
camera stuff has obvious homes in the usual driver hierarchy.
Brian
Hi!
> >> Can you resubmit it with the original author descriptions? ?It's not
> >> fair to them to have it shown up as coming from you.
> >
> > Yes, done... and thanks.
> >
> > Brian... I'd like to submit qdsp5 and smd code, too. Who should be
> > listed as their authors?
>
> smd is pretty much my fault at this point, though Arve hacks on the
> PM-related bits.
>
> The latest incarnation of the rpcrouter is me, with a lot of the
> original work by Iliyan, based heavily on the work Qualcomm did (thus
> their copyright on it as well as Google's).
>
> qdsp5 is Iliyan.
>
> Might be worth breaking these into at least three pieces (smd,
> rpcrouter, qdsp5)?
Sorry, I already submitted the patch. I just listed everyone I could
find in the sources in From: ; that included san@google but not
Arve. I hope that's not too bad.
> Are you highly opposed to having smd and rpcrouter under
> arch/arm/mach-msm? They're (for better or worse) pretty integral to
> the core operation of the platform (suspend/resume and a lot of other
> core SoC functions require coordination with the modem core).
I am not opposed to having the code under mach-msm/ ... it would be
actually preffered. But it is quite a lot of code, and I guess it
makes sense to clean it up in staging/ then move it to the proper
place.
Alternatively if you can create nice git series for rmk/-next; that
would work, too.
But I guess that staging/ stuff is quite easy to remove, and useful
for people that want to use the phones in the meantime :-).
> The qdsp5 stuff could exist elsewhere easily (though I'm not sure
> where the logical place is), and stuff on top of it like the v4l2
> camera stuff has obvious homes in the usual driver hierarchy.
Ack.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Thu, Jul 09, 2009 at 11:53:23AM +0200, Pavel Machek wrote:
> Hi!
>
> > >> Can you resubmit it with the original author descriptions? ?It's not
> > >> fair to them to have it shown up as coming from you.
> > >
> > > Yes, done... and thanks.
> > >
> > > Brian... I'd like to submit qdsp5 and smd code, too. Who should be
> > > listed as their authors?
> >
> > smd is pretty much my fault at this point, though Arve hacks on the
> > PM-related bits.
> >
> > The latest incarnation of the rpcrouter is me, with a lot of the
> > original work by Iliyan, based heavily on the work Qualcomm did (thus
> > their copyright on it as well as Google's).
> >
> > qdsp5 is Iliyan.
> >
> > Might be worth breaking these into at least three pieces (smd,
> > rpcrouter, qdsp5)?
>
> Sorry, I already submitted the patch. I just listed everyone I could
> find in the sources in From: ; that included san@google but not
> Arve. I hope that's not too bad.
Please split the patch up into the different pieces, with the different
authors. You shouldn't be sending patches that do more than one thing
at a time anyway :)
thanks,
greg k-h