From: Julia Lawall <[email protected]>
The variable client is initialized twice to the same (side effect-free)
expression. Drop one initialization.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@
x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>
Signed-off-by: Julia Lawall <[email protected]>
---
fs/ceph/addr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index eab46b0..8686018 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -567,9 +567,9 @@ static int ceph_writepages_start(struct address_space *mapping,
struct inode *inode = mapping->host;
struct backing_dev_info *bdi = mapping->backing_dev_info;
struct ceph_inode_info *ci = ceph_inode(inode);
- struct ceph_client *client = ceph_inode_to_client(inode);
+ struct ceph_client *client;
pgoff_t index, start, end;
int range_whole = 0;
int should_loop = 1;
On Sat, 16 Jan 2010, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> The variable client is initialized twice to the same (side effect-free)
> expression. Drop one initialization.
Applied to the ceph tree.
Thanks-
sage